Skip to content

Commit 976cdf1

Browse files
committed
untag tests not working without stdout/stderr flush
1 parent 8fd57f6 commit 976cdf1

File tree

2 files changed

+13
-22
lines changed

2 files changed

+13
-22
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_warnings.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55
*graalpython.lib-python.3.test.test_warnings.__init__.CCatchWarningTests.test_check_warnings
66
*graalpython.lib-python.3.test.test_warnings.__init__.CCatchWarningTests.test_record_override_showwarning_before
77
*graalpython.lib-python.3.test.test_warnings.__init__.CCatchWarningTests.test_record_override_showwarning_inside
8-
*graalpython.lib-python.3.test.test_warnings.__init__.CEnvironmentVariableTests.test_comma_separated_warnings
9-
*graalpython.lib-python.3.test.test_warnings.__init__.CEnvironmentVariableTests.test_envvar_and_command_line
10-
*graalpython.lib-python.3.test.test_warnings.__init__.CEnvironmentVariableTests.test_nonascii
11-
*graalpython.lib-python.3.test.test_warnings.__init__.CEnvironmentVariableTests.test_single_warning
128
*graalpython.lib-python.3.test.test_warnings.__init__.CFilterTests.test_always
139
*graalpython.lib-python.3.test.test_warnings.__init__.CFilterTests.test_always_after_default
1410
*graalpython.lib-python.3.test.test_warnings.__init__.CFilterTests.test_append_duplicate
@@ -48,10 +44,6 @@
4844
*graalpython.lib-python.3.test.test_warnings.__init__.PyCatchWarningTests.test_check_warnings
4945
*graalpython.lib-python.3.test.test_warnings.__init__.PyCatchWarningTests.test_record_override_showwarning_before
5046
*graalpython.lib-python.3.test.test_warnings.__init__.PyCatchWarningTests.test_record_override_showwarning_inside
51-
*graalpython.lib-python.3.test.test_warnings.__init__.PyEnvironmentVariableTests.test_comma_separated_warnings
52-
*graalpython.lib-python.3.test.test_warnings.__init__.PyEnvironmentVariableTests.test_envvar_and_command_line
53-
*graalpython.lib-python.3.test.test_warnings.__init__.PyEnvironmentVariableTests.test_nonascii
54-
*graalpython.lib-python.3.test.test_warnings.__init__.PyEnvironmentVariableTests.test_single_warning
5547
*graalpython.lib-python.3.test.test_warnings.__init__.PyFilterTests.test_always
5648
*graalpython.lib-python.3.test.test_warnings.__init__.PyFilterTests.test_always_after_default
5749
*graalpython.lib-python.3.test.test_warnings.__init__.PyFilterTests.test_append_duplicate

graalpython/lib-graalpython/pyio_patches.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -96,20 +96,19 @@ def open(*args, **kwargs):
9696
sys.__stderr__ = sys.stderr
9797

9898

99-
# Try to close the std streams when we exit
100-
import atexit
101-
def close_stdouts(so=sys.stdout, se=sys.stderr):
102-
try:
103-
so.close()
104-
except:
105-
pass
106-
try:
107-
se.close()
108-
except:
109-
pass
110-
111-
112-
atexit.register(close_stdouts)
99+
# Try to close the std streams when we exit. This currently doesn't work due to GR-25185
100+
# To make this work reliably, we probably have to implement the _io module in Java
101+
# import atexit
102+
# def close_stdouts(so=sys.stdout, se=sys.stderr):
103+
# try:
104+
# so.close()
105+
# except:
106+
# pass
107+
# try:
108+
# se.close()
109+
# except:
110+
# pass
111+
# atexit.register(close_stdouts)
113112

114113

115114
# See comment in _pyio.py. This method isn't strictly necessary and is provided

0 commit comments

Comments
 (0)