use lenient CPython behavior for uint CAPI members

Author: lukasstadler

graalpython/com.oracle.graal.python.test/src/tests/cpyext/test_member.py

@@ -228,6 +228,8 @@ def test_member(self):
             val = getattr(obj, m)
             assert val != min_values[i], "was: %r" % getattr(obj, m)
             assert_raises(TypeError, setattr, obj, m, "hello")
+            assert_raises(OverflowError, setattr, obj, m, int(-1e40))
+            assert_raises(OverflowError, setattr, obj, m, int(1e40))
 
         # T_LONG, T_ULONG, T_PYSSIZET
         max_values = (0x7FFFFFFFFFFFFFFF, 0xFFFFFFFFFFFFFFFF, 0x7FFFFFFFFFFFFFFF, 0x7FFFFFFFFFFFFFFF, 0xFFFFFFFFFFFFFFFF)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiMemberAccessNodes.java

@@ -89,6 +89,7 @@
 import com.oracle.graal.python.nodes.object.GetClassNode;
 import com.oracle.graal.python.nodes.object.IsBuiltinClassProfile;
 import com.oracle.graal.python.runtime.exception.PException;
+import com.oracle.graal.python.runtime.exception.PythonErrorType;
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
@@ -437,8 +438,23 @@ abstract static class WriteUIntNode extends WriteTypeNode {
         @Specialization
         static void write(Object pointer, Object newValue,
                         @Cached AsNativePrimitiveNode asLong,
-                        @Cached CStructAccess.WriteIntNode write) {
-            write.write(pointer, (int) asLong.toUInt64(newValue, true));
+                        @Cached CStructAccess.WriteIntNode write,
+                        @Cached PRaiseNode raiseNode,
+                        @Cached IsBuiltinClassProfile exceptionProfile) {
+            /*
+             * This emulates the arguably buggy behavior from CPython where it accepts MIN_LONG to
+             * MAX_ULONG values.
+             */
+            try {
+                write.write(pointer, (int) asLong.toUInt64(newValue, true));
+            } catch (PException e) {
+                /*
+                 * Special case: accept signed long as well.
+                 */
+                e.expectOverflowError(exceptionProfile);
+                write.write(pointer, (int) asLong.toInt64(newValue, true));
+                // swallowing the exception
+            }
         }
     }