string.__add__ is not commutative

timfel · timfel · commit 9893a9f42ef5 · 2020-06-10T14:08:15.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java
@@ -340,7 +340,7 @@ boolean operator(String self, String other) {
         }
     }
 
-    @Builtin(name = __RADD__, minNumOfPositionalArgs = 2)
+    @Builtin(name = __RADD__, minNumOfPositionalArgs = 2, reverseOperation = true)
     @Builtin(name = __ADD__, minNumOfPositionalArgs = 2)
     @GenerateNodeFactory
     public abstract static class AddNode extends PythonBinaryBuiltinNode {

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ boolean operator(String self, String other) {`
`340`	`340`	`}`
`341`	`341`	`}`
`342`	`342`
`343`		`- @Builtin(name = __RADD__, minNumOfPositionalArgs = 2)`
	`343`	`+ @Builtin(name = __RADD__, minNumOfPositionalArgs = 2, reverseOperation = true)`
`344`	`344`	`@Builtin(name = __ADD__, minNumOfPositionalArgs = 2)`
`345`	`345`	`@GenerateNodeFactory`
`346`	`346`	`public abstract static class AddNode extends PythonBinaryBuiltinNode {`