Fix unchecked cast warnings

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiContext.java

@@ -51,7 +51,6 @@
 import java.util.Objects;
 import java.util.logging.Level;
 
-import com.oracle.graal.python.builtins.objects.cext.common.ReferenceStack;
 import org.graalvm.collections.EconomicMap;
 
 import com.oracle.graal.python.PythonLanguage;
@@ -68,6 +67,7 @@
 import com.oracle.graal.python.builtins.objects.cext.capi.NativeObjectReferenceArrayWrapper.PointerArrayWrapper;
 import com.oracle.graal.python.builtins.objects.cext.capi.NativeObjectReferenceArrayWrapper.RefCountArrayWrapper;
 import com.oracle.graal.python.builtins.objects.cext.common.CExtContext;
+import com.oracle.graal.python.builtins.objects.cext.common.ReferenceStack;
 import com.oracle.graal.python.builtins.objects.frame.PFrame;
 import com.oracle.graal.python.builtins.objects.function.PArguments;
 import com.oracle.graal.python.builtins.objects.function.Signature;
@@ -136,7 +136,7 @@ public final class CApiContext extends CExtContext {
     public CApiContext(PythonContext context, Object hpyLibrary) {
         super(context, hpyLibrary, CAPIConversionNodeSupplier.INSTANCE);
         nativeObjectsQueue = new ReferenceQueue<>();
-        nativeObjectWrapperList = new ReferenceStack<>(NativeObjectReference.class);
+        nativeObjectWrapperList = new ReferenceStack<>();
 
         // avoid 0 to be used as ID
         int nullID = nativeObjectWrapperList.reserve();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/common/ReferenceStack.java

@@ -40,7 +40,6 @@
  */
 package com.oracle.graal.python.builtins.objects.cext.common;
 
-import java.lang.reflect.Array;
 import java.util.Arrays;
 import java.util.Iterator;
 
@@ -50,11 +49,11 @@ public final class ReferenceStack<T> implements Iterable<T> {
     private static final int INITIAL_CAPACITY = 64;
 
     private final IntegerStack freeList;
-    private T[] nativeObjectWrapperList;
+    private Object[] nativeObjectWrapperList;
 
     @TruffleBoundary
-    public ReferenceStack(Class<T> elementClazz) {
-        nativeObjectWrapperList = (T[]) Array.newInstance(elementClazz, INITIAL_CAPACITY);
+    public ReferenceStack() {
+        nativeObjectWrapperList = new Object[INITIAL_CAPACITY];
         freeList = new IntegerStack(INITIAL_CAPACITY);
         freeList.addToFreeList(0, INITIAL_CAPACITY);
     }
@@ -67,14 +66,16 @@ private void enlargeNativeReferenceList() {
         freeList.addToFreeList(oldSize, newSize);
     }
 
+    @SuppressWarnings("unchecked")
     public T get(int idx) {
         assert 0 <= idx && idx < nativeObjectWrapperList.length;
-        return nativeObjectWrapperList[idx];
+        return (T) nativeObjectWrapperList[idx];
     }
 
+    @SuppressWarnings("unchecked")
     public T remove(int idx) {
         assert 0 <= idx && idx < nativeObjectWrapperList.length;
-        T ref = nativeObjectWrapperList[idx];
+        T ref = (T) nativeObjectWrapperList[idx];
         nativeObjectWrapperList[idx] = null;
         freeList.push(idx);
         return ref;
@@ -96,16 +97,18 @@ public void commit(int idx, T nativeObjectReference) {
         nativeObjectWrapperList[idx] = nativeObjectReference;
     }
 
+    @SuppressWarnings("unchecked")
     public T resurrect(int idx, T nativeObjectReference) {
         assert 0 <= idx && idx < nativeObjectWrapperList.length;
-        T old = nativeObjectWrapperList[idx];
+        T old = (T) nativeObjectWrapperList[idx];
         nativeObjectWrapperList[idx] = nativeObjectReference;
         return old;
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public Iterator<T> iterator() {
-        return Arrays.asList(nativeObjectWrapperList).iterator();
+        return (Iterator<T>) Arrays.asList(nativeObjectWrapperList).iterator();
     }
 
     static final class IntegerStack {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/hpy/GraalHPyContext.java

@@ -327,7 +327,7 @@ public static HPyContextMembers getByName(String name) {
 
     @CompilationFinal private ReferenceQueue<Object> nativeSpaceReferenceQueue;
     @CompilationFinal private RootCallTarget referenceCleanerCallTarget;
-    public final ReferenceStack<GraalHPyHandleReference> references = new ReferenceStack<>(GraalHPyHandleReference.class);
+    public final ReferenceStack<GraalHPyHandleReference> references = new ReferenceStack<>();
 
     public GraalHPyContext(PythonContext context, Object hpyLibrary) {
         super(context, hpyLibrary, GraalHPyConversionNodeSupplier.HANDLE);
@@ -908,7 +908,7 @@ void createHandleReference(PythonObject pythonObject, Object dataPtr, Object des
     private ReferenceQueue<Object> ensureReferenceQueue() {
         if (nativeSpaceReferenceQueue == null) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
-            final ReferenceQueue referenceQueue = new ReferenceQueue<>();
+            final ReferenceQueue<Object> referenceQueue = new ReferenceQueue<>();
 
             // lazily register the runnable that concurrently collects the queued references
             getContext().registerAsyncAction(() -> {