Address review feedback

Author: msimacek

graalpython/com.oracle.graal.python.cext/src/unicodeobject.c

@@ -93,7 +93,7 @@ static PyObject * _PyUnicode_FromUCS1(const Py_UCS1 *s, Py_ssize_t size);
 static PyObject * _PyUnicode_FromUCS2(const Py_UCS2 *s, Py_ssize_t size);
 static PyObject * _PyUnicode_FromUCS4(const Py_UCS4 *s, Py_ssize_t size);
 
-static inline void* convert_errors(const char *errors) {
+static MUST_INLINE void* convert_errors(const char *errors) {
     return errors != NULL ? polyglot_from_string(errors, SRC_CS) : polyglot_from_string("strict", SRC_CS);
 }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ImpModuleBuiltins.java

@@ -388,12 +388,18 @@ public abstract static class SourceHashNode extends PythonBinaryClinicBuiltinNod
         @Specialization
         PBytes run(long magicNumber, Object sourceBuffer,
                         @Cached BytesNodes.HashBufferNode hashBufferNode) {
+            long sourceHash = hashBufferNode.execute(sourceBuffer);
+            return factory().createBytes(computeHash(magicNumber, sourceHash));
+        }
+
+        @TruffleBoundary
+        private static byte[] computeHash(long magicNumber, long sourceHash) {
             byte[] hash = new byte[Long.BYTES];
-            long hashCode = magicNumber ^ hashBufferNode.execute(sourceBuffer);
+            long hashCode = magicNumber ^ sourceHash;
             for (int i = 0; i < hash.length; i++) {
                 hash[i] = (byte) (hashCode << (8 * i));
             }
-            return factory().createBytes(hash);
+            return hash;
         }
 
         @Override

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/BytesNodes.java

@@ -869,6 +869,11 @@ static long hashDirect(Object buffer,
             PythonBufferAccessLibrary.assertIsBuffer(buffer);
             int len = bufferLib.getBufferLength(buffer);
             byte[] array = bufferLib.getInternalByteArray(buffer);
+            return computeHash(len, array);
+        }
+
+        @TruffleBoundary
+        private static int computeHash(int len, byte[] array) {
             int result = 1;
             for (int i = 0; i < len; i++) {
                 result = 31 * result + array[i];

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/method/AbstractMethodBuiltins.java

@@ -178,16 +178,12 @@ abstract static class GetModuleNode extends PythonBinaryBuiltinNode {
         Object getModule(VirtualFrame frame, PBuiltinMethod self, @SuppressWarnings("unused") PNone none,
                         @Cached PyObjectLookupAttr lookup,
                         @CachedLibrary("self") DynamicObjectLibrary dylib) {
+            // No profiling, performance here is not very important
             Object module = dylib.getOrDefault(self, __MODULE__, PNone.NO_VALUE);
             if (module != PNone.NO_VALUE) {
                 return module;
             }
             if (self.getSelf() instanceof PythonModule) {
-                /*
-                 * 'getThreadStateNode' acts as a branch profile. This indirect call is done to
-                 * easily support calls to this builtin with and without virtual frame, and because
-                 * we don't care much about the performance here anyway
-                 */
                 PythonLanguage language = getLanguage();
                 Object state = IndirectCallContext.enter(frame, language, getContext(), this);
                 try {