Skip to content

Commit 99ea21c

Browse files
author
Franziska Geiger
committed
Style issues fix. Not just my changes but also some other pylint errors I found.
1 parent e48b495 commit 99ea21c

File tree

5 files changed

+17
-22
lines changed

5 files changed

+17
-22
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/HashingStorageNodes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ protected boolean contains(@SuppressWarnings("unused") VirtualFrame frame, Keywo
523523
if (profileKey instanceof String) {
524524
return storage.hasKey(profileKey, DEFAULT_EQIVALENCE);
525525
} else if (profileKey instanceof PString) {
526-
if(wrappedString((PString) profileKey) || lookupHash.execute(key, __HASH__) == lookupStringHash.execute(PythonBuiltinClassType.PString, __HASH__)){
526+
if (wrappedString((PString) profileKey) || lookupHash.execute(key, __HASH__) == lookupStringHash.execute(PythonBuiltinClassType.PString, __HASH__)) {
527527
return storage.hasKey(((PString) profileKey).getValue(), DEFAULT_EQIVALENCE);
528528
}
529529
CompilerDirectives.transferToInterpreter();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/formatting/StringFormatter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ private static Object asNumber(Object arg, CallNode callNode, BiFunction<Object,
123123
} else if (arg instanceof Double) {
124124
// A common case where it is safe to return arg.__int__()
125125
return ((Double) arg).intValue();
126-
} else if(arg instanceof Boolean) {
127-
return (Boolean)arg ? 1 : 0;
126+
} else if (arg instanceof Boolean) {
127+
return (Boolean) arg ? 1 : 0;
128128
} else if (arg instanceof PFloat) {
129129
return (int) ((PFloat) arg).getValue();
130130
} else if (arg instanceof PythonAbstractObject) {

mx.graalpython/mx_graalpython.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import shutil
3232
import sys
3333
import tempfile
34-
import time
3534
from argparse import ArgumentParser
3635

3736
import mx
@@ -1041,13 +1040,13 @@ def python_build_watch(args):
10411040
if sum([args.full, args.graalvm, args.no_java]) > 1:
10421041
mx.abort("Only one of --full, --graalvm, --no-java can be specified")
10431042
if args.full:
1044-
suffixes = [".c", ".h", ".class", ".jar", ".java"]
1043+
# suffixes = [".c", ".h", ".class", ".jar", ".java"]
10451044
excludes = [".*\\.py$"]
10461045
elif args.graalvm:
1047-
suffixes = [".c", ".h", ".class", ".jar", ".java", ".py"]
1046+
# suffixes = [".c", ".h", ".class", ".jar", ".java", ".py"]
10481047
excludes = ["mx_.*\\.py$"]
10491048
else:
1050-
suffixes = [".c", ".h", ".class", ".jar"]
1049+
# suffixes = [".c", ".h", ".class", ".jar"]
10511050
excludes = [".*\\.py$", ".*\\.java$"]
10521051

10531052
cmd = ["inotifywait", "-q", "-e", "close_write,moved_to", "-r", "--format=%f"]

mx.graalpython/mx_graalpython_benchmark.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
# OF THE POSSIBILITY OF SUCH DAMAGE.
2424
from __future__ import print_function
2525

26-
import argparse
2726
import os
2827
import re
2928
from abc import ABCMeta, abstractproperty, abstractmethod

mx.graalpython/suite.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,14 @@
9191
],
9292
"sha1": "7a5960b8062ddbf0c0e79f806e23785d55fec3c8",
9393
},
94-
"XZ-1.8" : {
95-
"sha1" : "c4f7d054303948eb6a4066194253886c8af07128",
96-
"maven" : {
97-
"groupId" : "org.tukaani",
98-
"artifactId" : "xz",
99-
"version" : "1.8",
100-
},
101-
},
102-
94+
"XZ-1.8": {
95+
"sha1": "c4f7d054303948eb6a4066194253886c8af07128",
96+
"maven": {
97+
"groupId": "org.tukaani",
98+
"artifactId": "xz",
99+
"version": "1.8",
100+
},
101+
},
103102

104103
},
105104

@@ -160,7 +159,6 @@
160159
},
161160
},
162161

163-
164162
"projects": {
165163
# GRAALPYTHON ANTLR
166164
"com.oracle.graal.python.parser.antlr": {
@@ -204,11 +202,11 @@
204202
],
205203
"buildDependencies": ["com.oracle.graal.python.parser.antlr"],
206204
"jacoco": "include",
207-
"javaCompliance" : "8+",
208-
"checkstyleVersion" : "8.8",
205+
"javaCompliance": "8+",
206+
"checkstyleVersion": "8.8",
209207
"annotationProcessors": ["truffle:TRUFFLE_DSL_PROCESSOR"],
210208
"workingSets": "Truffle,Python",
211-
"spotbugsIgnoresGenerated" : True,
209+
"spotbugsIgnoresGenerated": True,
212210
},
213211

214212
# GRAALPYTHON TEST
@@ -242,7 +240,6 @@
242240
"testProject": True,
243241
},
244242

245-
246243
"com.oracle.graal.python.cext": {
247244
"subDir": "graalpython",
248245
"native": True,

0 commit comments

Comments
 (0)