posix module: open create a temp file if DELETE_ON_CLOSE is set

- uses Files.createTempFile until TruffleFile API supports the creation of temp files

- explicit logic for creating temporary files in the specified path
- files are deleted on jvm exit

- add test_tempfile case

Author: cosminbasca

graalpython/com.oracle.graal.python.test/src/tests/test_subprocess.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2018, Oracle and/or its affiliates.
+# Copyright (c) 2018, 2019, Oracle and/or its affiliates.
 # Copyright (C) 1996-2017 Python Software Foundation
 #
 # Licensed under the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2

graalpython/com.oracle.graal.python.test/src/tests/test_tempfile.py

@@ -0,0 +1,58 @@
+# Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+#
+# The Universal Permissive License (UPL), Version 1.0
+#
+# Subject to the condition set forth below, permission is hereby granted to any
+# person obtaining a copy of this software, associated documentation and/or
+# data (collectively the "Software"), free of charge and under any and all
+# copyright rights in the Software, and any and all patent rights owned or
+# freely licensable by each licensor hereunder covering either (i) the
+# unmodified Software as contributed to or provided by such licensor, or (ii)
+# the Larger Works (as defined below), to deal in both
+#
+# (a) the Software, and
+#
+# (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+# one is included with the Software each a "Larger Work" to which the Software
+# is contributed by such licensors),
+#
+# without restriction, including without limitation the rights to copy, create
+# derivative works of, display, perform, and distribute the Software and make,
+# use, sell, offer for sale, import, export, have made, and have sold the
+# Software and the Larger Work(s), and to sublicense the foregoing rights on
+# either these or other terms.
+#
+# This license is subject to the following condition:
+#
+# The above copyright notice and either this complete permission notice or at a
+# minimum a reference to the UPL must be included in all copies or substantial
+# portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+
+def assert_raises(err, fn, *args, **kwargs):
+    raised = False
+    try:
+        fn(*args, **kwargs)
+    except err:
+        raised = True
+    assert raised
+
+
+def test_create():
+    from tempfile import TemporaryFile
+    try:
+        f = TemporaryFile()
+        assert f is not None
+        f.close()
+    except:
+        assert False
+

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -30,6 +30,7 @@
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.OSError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
+import static com.oracle.graal.python.util.TempFileUtils.getRandomFilePath;
 import static com.oracle.truffle.api.TruffleFile.CREATION_TIME;
 import static com.oracle.truffle.api.TruffleFile.IS_DIRECTORY;
 import static com.oracle.truffle.api.TruffleFile.IS_REGULAR_FILE;
@@ -541,7 +542,7 @@ public abstract static class StatNode extends PythonBinaryBuiltinNode {
 
         @Specialization
         Object doStatPath(VirtualFrame frame, Object path, boolean followSymlinks,
-                          @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             return stat(cast.execute(frame, path), followSymlinks);
         }
 
@@ -845,7 +846,7 @@ public abstract static class ScandirIterNode extends PythonBinaryBuiltinNode {
 
         @Specialization
         Object doit(VirtualFrame frame, LazyPythonClass cls, Object pathArg,
-                    @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String path = cast.execute(frame, pathArg);
             try {
                 TruffleFile file = getContext().getEnv().getPublicTruffleFile(path);
@@ -865,7 +866,7 @@ public abstract static class DirEntryNode extends PythonTernaryBuiltinNode {
 
         @Specialization
         Object doit(VirtualFrame frame, LazyPythonClass cls, String name, Object pathArg,
-                    @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String path = cast.execute(frame, pathArg);
             try {
                 TruffleFile dir = getContext().getEnv().getPublicTruffleFile(path);
@@ -912,19 +913,26 @@ public abstract static class OpenNode extends PythonFileNode {
 
         @Specialization(guards = {"isNoValue(mode)", "isNoValue(dir_fd)"})
         Object open(VirtualFrame frame, Object pathname, int flags, @SuppressWarnings("unused") PNone mode, PNone dir_fd,
-                    @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             return openMode(frame, pathname, flags, 0777, dir_fd, cast);
         }
 
         @Specialization(guards = {"isNoValue(dir_fd)"})
         Object openMode(VirtualFrame frame, Object pathArg, int flags, int fileMode, @SuppressWarnings("unused") PNone dir_fd,
-                    @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String pathname = cast.execute(frame, pathArg);
             Set<StandardOpenOption> options = flagsToOptions(flags);
             FileAttribute<Set<PosixFilePermission>>[] attributes = modeToAttributes(fileMode);
-            TruffleFile truffleFile = getContext().getPublicTruffleFileRelaxed(pathname, PythonLanguage.DEFAULT_PYTHON_EXTENSIONS);
+            TruffleFile truffleFile;
             try {
-                SeekableByteChannel fc = truffleFile.newByteChannel(options, attributes);
+                SeekableByteChannel fc;
+                if (options.contains(StandardOpenOption.DELETE_ON_CLOSE)) {
+                    // TODO: (cbas) remove patch once the TruffleFile API supports temp file
+                    // creation -> GR-17515
+                    pathname = getRandomFilePath(pathname, options);
+                }
+                truffleFile = getContext().getPublicTruffleFileRelaxed(pathname, PythonLanguage.DEFAULT_PYTHON_EXTENSIONS);
+                fc = truffleFile.newByteChannel(options, attributes);
                 return getResources().open(truffleFile, fc);
             } catch (NoSuchFileException e) {
                 gotException.enter();
@@ -1076,7 +1084,7 @@ public abstract static class UnlinkNode extends PythonFileNode {
 
         @Specialization
         Object unlink(VirtualFrame frame, Object pathArg,
-                      @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String path = cast.execute(frame, pathArg);
             try {
                 getContext().getEnv().getPublicTruffleFile(path).delete();
@@ -1106,13 +1114,13 @@ public abstract static class MkdirNode extends PythonFileNode {
 
         @Specialization
         Object mkdir(VirtualFrame frame, Object path, @SuppressWarnings("unused") PNone mode, PNone dirFd,
-                     @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             return mkdirMode(frame, path, 511, dirFd, cast);
         }
 
         @Specialization
         Object mkdirMode(VirtualFrame frame, Object pathArg, @SuppressWarnings("unused") int mode, @SuppressWarnings("unused") PNone dirFd,
-                     @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String path = cast.execute(frame, pathArg);
             try {
                 getContext().getEnv().getPublicTruffleFile(path).createDirectory();
@@ -1263,13 +1271,13 @@ abstract static class ChmodNode extends PythonBuiltinNode {
 
         @Specialization
         Object chmod(VirtualFrame frame, Object path, long mode, @SuppressWarnings("unused") PNone dir_fd, @SuppressWarnings("unused") PNone follow_symlinks,
-                     @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             return chmodFollow(frame, path, mode, dir_fd, true, cast);
         }
 
         @Specialization
         Object chmodFollow(VirtualFrame frame, Object pathArg, long mode, @SuppressWarnings("unused") PNone dir_fd, boolean follow_symlinks,
-                           @Cached CastToPathNode cast) {
+                        @Cached CastToPathNode cast) {
             String path = cast.execute(frame, pathArg);
             Set<PosixFilePermission> permissions = modeToPermissions(mode);
             try {
@@ -1472,7 +1480,7 @@ PTuple waitpid(VirtualFrame frame, int pid, int options) {
         @SuppressWarnings("unused")
         @Specialization
         PTuple waitpidFallback(VirtualFrame frame, Object pid, Object options,
-                       @Cached CastToIndexNode castToInt) {
+                        @Cached CastToIndexNode castToInt) {
             return waitpid(frame, castToInt.execute(pid), castToInt.execute(options));
         }
     }
@@ -1908,8 +1916,8 @@ String ctermid() {
     @GenerateNodeFactory
     @TypeSystemReference(PythonArithmeticTypes.class)
     abstract static class KillNode extends PythonBinaryBuiltinNode {
-        private static final String[] KILL_SIGNALS = new String[] { "SIGKILL", "SIGQUIT", "SIGTRAP", "SIGABRT" };
-        private static final String[] TERMINATION_SIGNALS = new String[] { "SIGTERM", "SIGINT" };
+        private static final String[] KILL_SIGNALS = new String[]{"SIGKILL", "SIGQUIT", "SIGTRAP", "SIGABRT"};
+        private static final String[] TERMINATION_SIGNALS = new String[]{"SIGTERM", "SIGINT"};
 
         @Specialization
         PNone kill(VirtualFrame frame, int pid, int signal,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/module/ModuleBuiltins.java

@@ -83,7 +83,7 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
         return ModuleBuiltinsFactory.getFactories();
     }
 
-    @Builtin(name = __INIT__ , minNumOfPositionalArgs = 2, maxNumOfPositionalArgs = 3, declaresExplicitSelf = true)
+    @Builtin(name = __INIT__, minNumOfPositionalArgs = 2, maxNumOfPositionalArgs = 3, declaresExplicitSelf = true)
     @GenerateNodeFactory
     @TypeSystemReference(PythonArithmeticTypes.class)
     public abstract static class ModuleNode extends PythonBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/module/PythonModule.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2018, Oracle and/or its affiliates.
+ * Copyright (c) 2017, 2019, Oracle and/or its affiliates.
  * Copyright (c) 2013, Regents of the University of California
  *
  * All rights reserved.

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/ReadAttributeFromObjectNode.java

@@ -119,7 +119,7 @@ protected static boolean isBuiltinDict(PHashingCollection globals, IsBuiltinClas
     }
 
     /**
-     * @param module  Non-cached parameter to help the DSL produce a guard, not an assertion
+     * @param module Non-cached parameter to help the DSL produce a guard, not an assertion
      */
     protected static HashingStorage getStorage(Object module, Object cachedGlobals) {
         return ((PDict) cachedGlobals).getDictStorage();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/util/CastToPathNode.java

@@ -125,6 +125,7 @@ String doObject(VirtualFrame frame, Object object,
     protected LookupAndCallUnaryNode createFsPathCall() {
         return LookupAndCallUnaryNode.create(SpecialMethodNames.__FSPATH__, () -> new NoAttributeHandler() {
             @Child PRaiseNode raise = PRaiseNode.create();
+
             @Override
             public Object execute(Object receiver) {
                 throw raise.raise(PythonBuiltinClassType.TypeError, ERROR_MESSAGE, receiver);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PosixResources.java

@@ -152,7 +152,8 @@ public PosixResources() {
         files.add(null);
         files.add(null);
         files.add(null);
-        children.add(new ProcessGroup(children)); // PID 0 is special, and refers to all processes in the process group
+        children.add(new ProcessGroup(children)); // PID 0 is special, and refers to all processes
+                                                  // in the process group
         inodes = new HashMap<>();
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/TempFileUtils.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * The Universal Permissive License (UPL), Version 1.0
+ *
+ * Subject to the condition set forth below, permission is hereby granted to any
+ * person obtaining a copy of this software, associated documentation and/or
+ * data (collectively the "Software"), free of charge and under any and all
+ * copyright rights in the Software, and any and all patent rights owned or
+ * freely licensable by each licensor hereunder covering either (i) the
+ * unmodified Software as contributed to or provided by such licensor, or (ii)
+ * the Larger Works (as defined below), to deal in both
+ *
+ * (a) the Software, and
+ *
+ * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+ * one is included with the Software each a "Larger Work" to which the Software
+ * is contributed by such licensors),
+ *
+ * without restriction, including without limitation the rights to copy, create
+ * derivative works of, display, perform, and distribute the Software and make,
+ * use, sell, offer for sale, import, export, have made, and have sold the
+ * Software and the Larger Work(s), and to sublicense the foregoing rights on
+ * either these or other terms.
+ *
+ * This license is subject to the following condition:
+ *
+ * The above copyright notice and either this complete permission notice or at a
+ * minimum a reference to the UPL must be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.oracle.graal.python.util;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.StandardOpenOption;
+import java.util.Random;
+import java.util.Set;
+
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+
+public final class TempFileUtils {
+    private static final String CHARS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+    private static final Random RANDOM = new Random(System.currentTimeMillis());
+
+    @TruffleBoundary
+    public static String getRandomString(int length) {
+        StringBuilder sb = new StringBuilder(length);
+        for (int i = 0; i < length; i++) {
+            sb.append(CHARS.charAt(RANDOM.nextInt(CHARS.length())));
+        }
+        return sb.toString();
+    }
+
+    public static String getRandomFilePath(String path, Set<StandardOpenOption> options) throws IOException {
+        return getRandomFilePath(path, null, null, options);
+    }
+
+    @TruffleBoundary
+    public static String getRandomFilePath(String path, String prefix, String suffix, Set<StandardOpenOption> options) throws IOException {
+        if (path == null) {
+            path = System.getProperty("java.io.tmpdir");
+        }
+        if (prefix == null) {
+            prefix = "";
+        }
+        if (suffix == null) {
+            suffix = "";
+        }
+
+        while (true) {
+            String tmpPath = path + File.separator + prefix + getRandomString(8) + suffix;
+            File tmpFile = new File(tmpPath);
+            if (!tmpFile.exists()) {
+                tmpFile.deleteOnExit();
+                if (tmpFile.createNewFile()) {
+                    options.remove(StandardOpenOption.CREATE_NEW);
+                    options.remove(StandardOpenOption.DELETE_ON_CLOSE);
+                    options.add(StandardOpenOption.CREATE);
+                    return tmpPath;
+                }
+            }
+        }
+    }
+}

graalpython/lib-graalpython/_ast.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 #
 # The Universal Permissive License (UPL), Version 1.0