Skip to content

Commit a1cb4ec

Browse files
committed
missing (c) for NumericSupport
- FloatUtils and IntNodes: make final
1 parent c329a10 commit a1cb4ec

File tree

3 files changed

+52
-6
lines changed

3 files changed

+52
-6
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/floats/FloatUtils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@
4848
/**
4949
* Contains helper methods for parsing float numbers in float() and complex() constructors.
5050
*/
51-
public abstract class FloatUtils {
51+
public final class FloatUtils {
52+
private FloatUtils() {
53+
}
54+
5255
public static int skipAsciiWhitespace(String str, int start, int len) {
5356
int offset = start;
5457
while (offset < len && isAsciiSpace(str.charAt(offset))) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntNodes.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@
5555
* Namespace containing equivalent nodes of {@code _Pylong_XXX} private function from
5656
* {@code longobject.c}
5757
*/
58-
public abstract class IntNodes {
58+
public final class IntNodes {
59+
private IntNodes() {
60+
}
61+
5962
/**
6063
* Equivalent of CPython's {@code _PyLong_Sign}. Return 0 if v is 0, -1 if v < 0, +1 if v > 0.
6164
*/

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/NumericSupport.java

Lines changed: 44 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,43 @@
1+
/*
2+
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
141
package com.oracle.graal.python.util;
242

343
import static com.oracle.graal.python.nodes.ErrorMessages.FLOAT_TO_LARGE_TO_PACK_WITH_S_FMT;
@@ -25,8 +65,8 @@ private NumericSupport(boolean bigEndian) {
2565
this.bigEndian = bigEndian;
2666
}
2767

28-
private final static NumericSupport BE_NUM_SUPPORT = new NumericSupport(true);
29-
private final static NumericSupport LE_NUM_SUPPORT = new NumericSupport(false);
68+
private static final NumericSupport BE_NUM_SUPPORT = new NumericSupport(true);
69+
private static final NumericSupport LE_NUM_SUPPORT = new NumericSupport(false);
3070

3171
public static NumericSupport bigEndian() {
3272
return BE_NUM_SUPPORT;
@@ -367,9 +407,9 @@ public static long asUnsigned(int value) {
367407

368408
@TruffleBoundary
369409
public static BigInteger asUnsigned(long value) {
370-
if (value >= 0L)
410+
if (value >= 0L) {
371411
return BigInteger.valueOf(value);
372-
else {
412+
} else {
373413
int upper = (int) (value >>> 32);
374414
int lower = (int) value;
375415

0 commit comments

Comments
 (0)