Fixed leaking file descriptors

Author: otethal

graalpython/com.oracle.graal.python.test/src/tests/test_subprocess.py

@@ -10,6 +10,8 @@ def test_os_pipe():
     r,w = os.pipe()
     written = os.write(w, b"hello")
     assert os.read(r, written) == b"hello"
+    os.close(r)
+    os.close(w)
 
 
 class TestSubprocess(unittest.TestCase):

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/socket/SocketBuiltins.java

@@ -178,10 +178,6 @@ abstract static class CloseNode extends PythonUnaryBuiltinNode {
         @Specialization
         @TruffleBoundary
         Object close(PSocket socket) {
-            if (!socket.isOpen()) {
-                return PNone.NONE;
-            }
-
             if (socket.getSocket() != null) {
                 try {
                     socket.getSocket().close();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/zipimporter/ZipImporterBuiltins.java

@@ -131,6 +131,12 @@ public LOCZipEntryStream(InputStream in) {
             this.in = in;
         }
 
+        @Override
+        public void close() throws IOException {
+            super.close();
+            in.close();
+        }
+
         @Override
         public int read() throws IOException {
             if (readFirstLoc) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PosixResources.java

@@ -351,7 +351,9 @@ public int openSocket(PSocket socket, PythonContext context) {
                 try {
                     PosixSupportLibrary posixLib = PosixSupportLibrary.getUncached();
                     if (nativeFdForSockets == -1) {
-                        nativeFdForSockets = posixLib.pipe(posixSupport)[0];
+                        int[] fds = posixLib.pipe(posixSupport);
+                        posixLib.close(posixSupport, fds[1]);
+                        nativeFdForSockets = fds[0];
                     }
                     fd = posixLib.dup(posixSupport, nativeFdForSockets);
                 } catch (PosixException e) {
@@ -366,6 +368,10 @@ public int openSocket(PSocket socket, PythonContext context) {
     @TruffleBoundary
     public void closeSocket(PSocket socket, PythonContext context) {
         int fd = socket.getFileno();
+        if (fd < 0) {
+            return;
+        }
+        socket.setFileno(-1);
         close(fd);
         Object posixSupport = context.getPosixSupport();
         if (posixSupport != this) {