Skip to content

Commit a2a38e3

Browse files
committed
Patch failing test
1 parent 781af9e commit a2a38e3

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_memoryview.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_release
3939
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_reversed
4040
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_setitem_readonly
41+
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_setitem_writable
4142
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_tobytes
4243
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_tolist
4344
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceSliceTest.test_toreadonly
@@ -59,6 +60,7 @@
5960
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_release
6061
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_reversed
6162
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_setitem_readonly
63+
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_setitem_writable
6264
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_tobytes
6365
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_tolist
6466
*graalpython.lib-python.3.test.test_memoryview.BytesMemorySliceTest.test_toreadonly
@@ -80,6 +82,7 @@
8082
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_release
8183
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_reversed
8284
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_setitem_readonly
85+
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_setitem_writable
8386
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_tobytes
8487
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_tolist
8588
*graalpython.lib-python.3.test.test_memoryview.BytesMemoryviewTest.test_toreadonly

graalpython/lib-python/3/test/test_memoryview.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,11 @@ def setitem(key, value):
116116
self.assertRaises(TypeError, setitem, "a", b"a")
117117
# Not implemented: multidimensional slices
118118
slices = (slice(0,1,1), slice(0,1,2))
119-
self.assertRaises(NotImplementedError, setitem, slices, b"a")
119+
# XXX GraalVM change - we raise TypeError instead of NotImplementedError because the dimensions are invalid.
120+
# Adding an expensive separate pre-check for multislices is not worth it and if CPython ever implements
121+
# multislices, this is going to raise the same TypeError as we do.
122+
# self.assertRaises(NotImplementedError, setitem, slices, b"a")
123+
self.assertRaises(TypeError, setitem, slices, b"a")
120124
# Trying to resize the memory object
121125
exc = ValueError if m.format == 'c' else TypeError
122126
self.assertRaises(exc, setitem, 0, b"")

0 commit comments

Comments
 (0)