Remove usage of Thread#stop, it throws UnsupportedOperationException on JDK 20

msimacek · msimacek · commit a7ab5c0bf10b · 2023-03-17T14:44:37.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java
@@ -2067,13 +2067,6 @@ protected void perform(ThreadLocalAction.Access access) {
                         });
                     }
                     if (isOurThread) {
-                        // Thread#stop is not supported on SVM
-                        if (!ImageInfo.inImageCode()) {
-                            if (thread.isAlive()) {
-                                LOGGER.warning("could not join thread " + thread.getName() + ". Trying to stop it.");
-                            }
-                            thread.stop();
-                        }
                         if (thread.isAlive()) {
                             LOGGER.warning("Could not stop thread " + thread.getName());
                         }

Original file line number	Diff line number	Diff line change
`@@ -2067,13 +2067,6 @@ protected void perform(ThreadLocalAction.Access access) {`
`2067`	`2067`	`});`
`2068`	`2068`	`}`
`2069`	`2069`	`if (isOurThread) {`
`2070`		`- // Thread#stop is not supported on SVM`
`2071`		`- if (!ImageInfo.inImageCode()) {`
`2072`		`- if (thread.isAlive()) {`
`2073`		`- LOGGER.warning("could not join thread " + thread.getName() + ". Trying to stop it.");`
`2074`		`- }`
`2075`		`- thread.stop();`
`2076`		`- }`
`2077`	`2070`	`if (thread.isAlive()) {`
`2078`	`2071`	`LOGGER.warning("Could not stop thread " + thread.getName());`
`2079`	`2072`	`}`