Skip to content

Commit a7c2d66

Browse files
committed
dictview builtins inherit from Unary and Binary builtins nodes as needed
1 parent c26c268 commit a7c2d66

File tree

1 file changed

+5
-6
lines changed
  • graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/dict

1 file changed

+5
-6
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/dict/DictViewBuiltins.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
import com.oracle.graal.python.builtins.objects.set.SetNodes;
6464
import com.oracle.graal.python.builtins.objects.tuple.PTuple;
6565
import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
66-
import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
6766
import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
6867
import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
6968
import com.oracle.truffle.api.dsl.Cached;
@@ -83,7 +82,7 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
8382

8483
@Builtin(name = __LEN__, fixedNumOfArguments = 1)
8584
@GenerateNodeFactory
86-
public abstract static class LenNode extends PythonBuiltinNode {
85+
public abstract static class LenNode extends PythonUnaryBuiltinNode {
8786
@Specialization
8887
Object len(PDictView self) {
8988
return self.getDict().size();
@@ -112,7 +111,7 @@ Object getItemsViewIter(PDictItemsView self) {
112111

113112
@Builtin(name = __CONTAINS__, fixedNumOfArguments = 2)
114113
@GenerateNodeFactory
115-
public abstract static class ContainsNode extends PythonBuiltinNode {
114+
public abstract static class ContainsNode extends PythonBinaryBuiltinNode {
116115
@SuppressWarnings("unused")
117116
@Specialization(guards = "self.getDict().size() == 0")
118117
boolean containsEmpty(PDictView self, Object key) {
@@ -141,7 +140,7 @@ boolean contains(PDictItemsView self, PTuple key,
141140

142141
@Builtin(name = __EQ__, fixedNumOfArguments = 2)
143142
@GenerateNodeFactory
144-
public abstract static class EqNode extends PythonBuiltinNode {
143+
public abstract static class EqNode extends PythonBinaryBuiltinNode {
145144

146145
@Specialization
147146
boolean doKeysView(PDictKeysView self, PDictKeysView other,
@@ -254,7 +253,7 @@ PBaseSet doItemsView(PDictItemsView self, PDictItemsView other,
254253

255254
@Builtin(name = __OR__, fixedNumOfArguments = 2)
256255
@GenerateNodeFactory
257-
public abstract static class OrNode extends PythonBuiltinNode {
256+
public abstract static class OrNode extends PythonBinaryBuiltinNode {
258257
@Specialization
259258
PBaseSet doKeysView(PDictKeysView self, PBaseSet other,
260259
@Cached("create()") HashingStorageNodes.UnionNode unionNode) {
@@ -287,7 +286,7 @@ PBaseSet doItemsView(PDictItemsView self, PDictItemsView other,
287286

288287
@Builtin(name = __XOR__, fixedNumOfArguments = 2)
289288
@GenerateNodeFactory
290-
public abstract static class XorNode extends PythonBuiltinNode {
289+
public abstract static class XorNode extends PythonBinaryBuiltinNode {
291290
@Specialization
292291
PBaseSet doKeysView(PDictKeysView self, PBaseSet other,
293292
@Cached("create()") HashingStorageNodes.ExclusiveOrNode xorNode) {

0 commit comments

Comments
 (0)