Skip to content

Commit aa7cde4

Browse files
committed
Removed public identifier on AllOrAnyNode + added static keyword to every all/any specialization method
Signed-off-by: Octave Larose <[email protected]>
1 parent 16b54b6 commit aa7cde4

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ public Object absObject(VirtualFrame frame, Object object,
297297
/**
298298
* Common class for all() and any() operations, as their logic and behaviors are very similar.
299299
*/
300-
public abstract static class AllOrAnyNode extends PNodeWithContext {
300+
abstract static class AllOrAnyNode extends PNodeWithContext {
301301
enum NodeType {
302302
ALL,
303303
ANY
@@ -382,39 +382,39 @@ protected boolean doHashStorage(VirtualFrame frame,
382382
public abstract static class AllNode extends PythonUnaryBuiltinNode {
383383

384384
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
385-
boolean doList(VirtualFrame frame,
385+
static boolean doList(VirtualFrame frame,
386386
PList object,
387387
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
388388
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
389389
return allOrAnyNode.execute(frame, object.getSequenceStorage(), AllOrAnyNode.NodeType.ALL);
390390
}
391391

392392
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
393-
boolean doTuple(VirtualFrame frame,
393+
static boolean doTuple(VirtualFrame frame,
394394
PTuple object,
395395
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
396396
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
397397
return allOrAnyNode.execute(frame, object.getSequenceStorage(), AllOrAnyNode.NodeType.ALL);
398398
}
399399

400400
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
401-
boolean doDict(VirtualFrame frame,
401+
static boolean doDict(VirtualFrame frame,
402402
PDict object,
403403
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
404404
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
405405
return allOrAnyNode.execute(frame, object.getDictStorage(), AllOrAnyNode.NodeType.ALL);
406406
}
407407

408408
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
409-
boolean doSet(VirtualFrame frame,
409+
static boolean doSet(VirtualFrame frame,
410410
PBaseSet object,
411411
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
412412
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
413413
return allOrAnyNode.execute(frame, object.getDictStorage(), AllOrAnyNode.NodeType.ALL);
414414
}
415415

416416
@Specialization
417-
boolean doObject(VirtualFrame frame,
417+
static boolean doObject(VirtualFrame frame,
418418
Object object,
419419
@Cached PyObjectGetIter getIter,
420420
@Cached GetNextNode nextNode,
@@ -442,39 +442,39 @@ boolean doObject(VirtualFrame frame,
442442
public abstract static class AnyNode extends PythonUnaryBuiltinNode {
443443

444444
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
445-
boolean doList(VirtualFrame frame,
445+
static boolean doList(VirtualFrame frame,
446446
PList object,
447447
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
448448
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
449449
return allOrAnyNode.execute(frame, object.getSequenceStorage(), AllOrAnyNode.NodeType.ANY);
450450
}
451451

452452
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
453-
boolean doTuple(VirtualFrame frame,
453+
static boolean doTuple(VirtualFrame frame,
454454
PTuple object,
455455
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
456456
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
457457
return allOrAnyNode.execute(frame, object.getSequenceStorage(), AllOrAnyNode.NodeType.ANY);
458458
}
459459

460460
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
461-
boolean doDict(VirtualFrame frame,
461+
static boolean doDict(VirtualFrame frame,
462462
PDict object,
463463
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
464464
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
465465
return allOrAnyNode.execute(frame, object.getDictStorage(), AllOrAnyNode.NodeType.ANY);
466466
}
467467

468468
@Specialization(guards = "cannotBeOverridden(object, getClassNode)", limit = "1")
469-
boolean doSet(VirtualFrame frame,
469+
static boolean doSet(VirtualFrame frame,
470470
PBaseSet object,
471471
@SuppressWarnings("unused") @Shared("getClassNode") @Cached GetClassNode getClassNode,
472472
@Shared("allOrAnyNode") @Cached AllOrAnyNode allOrAnyNode) {
473473
return allOrAnyNode.execute(frame, object.getDictStorage(), AllOrAnyNode.NodeType.ANY);
474474
}
475475

476476
@Specialization
477-
boolean doObject(VirtualFrame frame,
477+
static boolean doObject(VirtualFrame frame,
478478
Object object,
479479
@Cached PyObjectGetIter getIter,
480480
@Cached GetNextNode nextNode,

0 commit comments

Comments
 (0)