be unforgiving when a foreign object lies to use about what it can be unwrapped to

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/TruffleObjectBuiltins.java

@@ -151,7 +151,7 @@ static Object[] unpackForeignArray(Object left, InteropLibrary lib, PForeignToPT
                 return data;
             }
         } catch (UnsupportedMessageException | InvalidArrayIndexException e) {
-            // fall through
+            throw new IllegalStateException("object does not unpack as it claims to");
         }
         return null;
     }
@@ -208,7 +208,7 @@ Object doComparisonBool(Object left, Object right,
             try {
                 return op.executeObject(lib.asBoolean(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -218,7 +218,7 @@ Object doComparisonLong(Object left, Object right,
             try {
                 return op.executeObject(lib.asLong(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -228,7 +228,7 @@ Object doComparisonDouble(Object left, Object right,
             try {
                 return op.executeObject(lib.asDouble(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -277,7 +277,7 @@ Object doComparisonStringR(Object left, Object right,
             try {
                 return op.executeObject(right, lib.asString(left));
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -350,7 +350,7 @@ static Object doForeignArray(Object left, Object right,
                 try {
                     rightInt = lib.asInt(right);
                 } catch (UnsupportedMessageException e) {
-                    return PNotImplemented.NOT_IMPLEMENTED;
+                    throw new IllegalStateException("object does not unpack as it claims to");
                 }
                 Object[] unpackForeignArray = unpackForeignArray(left, lib, convert);
                 if (unpackForeignArray != null) {
@@ -466,7 +466,7 @@ Object doComparisonBool(Object left, Object right,
             try {
                 return comparisonNode.executeBool(lib.asBoolean(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -476,7 +476,7 @@ Object doComparisonLong(Object left, Object right,
             try {
                 return comparisonNode.executeWith(lib.asLong(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -486,7 +486,7 @@ Object doComparisonDouble(Object left, Object right,
             try {
                 return comparisonNode.executeWith(lib.asDouble(left), right);
             } catch (UnsupportedMessageException e) {
-                return PNotImplemented.NOT_IMPLEMENTED;
+                throw new IllegalStateException("object does not unpack as it claims to");
             }
         }
 
@@ -499,7 +499,7 @@ Object doComparison(@SuppressWarnings("unused") Object left, Object right,
         @SuppressWarnings("unused")
         @Fallback
         public PNotImplemented doGeneric(Object left, Object right) {
-            return PNotImplemented.NOT_IMPLEMENTED;
+            throw new IllegalStateException("object does not unpack as it claims to");
         }
     }