builtin starargs node extract info from iterable objects

- add basic unittest

Author: cosminbasca

graalpython/com.oracle.graal.python.test/src/tests/test_generators.py

@@ -168,3 +168,13 @@ def f():
 
 if sys.version_info.minor == 4 and sys.version_info.micro < 3:
     del ExceptionTest
+
+
+def test_generator_starargs():
+    def func(*args):
+        return set(args)
+
+    lst = [x for x in range(10)]
+    gen = (x for x in range(10))
+    assert func(*lst) == set(lst)
+    assert func(*gen) == set(lst)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/HashingStorage.java

@@ -237,7 +237,7 @@ public void addAll(HashingStorage other, Equivalence eq) {
     private Object[] iteratorAsArray(Iterable<Object> iterable) {
         Object[] items = new Object[this.length()];
         int i = 0;
-        for(Object item: iterable) {
+        for (Object item : iterable) {
             items[i++] = item;
         }
         return items;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/positional/ExecutePositionalStarargsNode.java

@@ -40,22 +40,29 @@
  */
 package com.oracle.graal.python.nodes.argument.positional;
 
+import java.util.ArrayList;
 import java.util.Iterator;
+import java.util.List;
 
 import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.dict.PDict;
 import com.oracle.graal.python.builtins.objects.list.PList;
 import com.oracle.graal.python.builtins.objects.set.PSet;
 import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.nodes.PNode;
+import com.oracle.graal.python.nodes.control.GetIteratorNode;
+import com.oracle.graal.python.nodes.control.GetNextNode;
+import com.oracle.graal.python.runtime.exception.PException;
+import com.oracle.graal.python.runtime.exception.PythonErrorType;
+import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.NodeChildren;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.nodes.Node;
+import com.oracle.truffle.api.profiles.ConditionProfile;
 
 @NodeChildren({@NodeChild(value = "splat", type = PNode.class)})
-public abstract class ExecutePositionalStarargsNode extends Node {
+public abstract class ExecutePositionalStarargsNode extends PNode {
     public abstract Object[] execute(VirtualFrame frame);
 
     public abstract Object[] executeWith(Object starargs);
@@ -110,6 +117,26 @@ Object[] starargs(PNone none) {
         return new Object[0];
     }
 
+    @Specialization
+    Object[] starargs(Object object,
+                      @Cached("create()") GetIteratorNode getIterator,
+                      @Cached("create()") GetNextNode next,
+                      @Cached("createBinaryProfile()") ConditionProfile errorProfile) {
+        Object iterator = getIterator.executeWith(object);
+        if (iterator != PNone.NO_VALUE && iterator != PNone.NONE) {
+            List<Object> internalStorage = new ArrayList<>();
+            while (true) {
+                try {
+                    internalStorage.add(next.execute(iterator));
+                } catch (PException e) {
+                    e.expectStopIteration(getCore(), errorProfile);
+                    return internalStorage.toArray();
+                }
+            }
+        }
+        throw raise(PythonErrorType.TypeError, "argument after * must be an iterable, not %p", object);
+    }
+
     public static ExecutePositionalStarargsNode create() {
         return ExecutePositionalStarargsNodeGen.create(null);
     }