Skip to content

Commit b06c9e5

Browse files
committed
don't repeat getGlobals in ReadGlobalOrBuiltinNode
1 parent 781ad31 commit b06c9e5

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/frame/ReadGlobalOrBuiltinNode.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
import com.oracle.truffle.api.CompilerDirectives;
5252
import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
5353
import com.oracle.truffle.api.Truffle;
54+
import com.oracle.truffle.api.dsl.Bind;
5455
import com.oracle.truffle.api.dsl.Cached;
5556
import com.oracle.truffle.api.dsl.CachedContext;
5657
import com.oracle.truffle.api.dsl.Specialization;
@@ -91,9 +92,10 @@ protected Object readGlobalCached(@SuppressWarnings("unused") VirtualFrame frame
9192
return returnGlobalOrBuiltin(result);
9293
}
9394

94-
@Specialization(guards = "isModule(getGlobals(frame))", replaces = "readGlobalCached")
95-
protected Object readGlobal(VirtualFrame frame) {
96-
Object result = readFromModuleNode.execute(PArguments.getGlobals(frame), attributeId);
95+
@Specialization(guards = "isModule(globals)", replaces = "readGlobalCached")
96+
protected Object readGlobal(@SuppressWarnings("unused") VirtualFrame frame,
97+
@Bind("getGlobals(frame)") Object globals) {
98+
Object result = readFromModuleNode.execute(globals, attributeId);
9799
return returnGlobalOrBuiltin(result);
98100
}
99101

0 commit comments

Comments
 (0)