Skip to content

Commit b121170

Browse files
committed
Fix a few more pyright errors
1 parent 3750dd9 commit b121170

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

mx.graalpython/mx_graalpython.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
from pathlib import Path
4242
from textwrap import dedent
4343

44-
from typing import cast
44+
from typing import cast, Union
4545

4646
import downstream_tests
4747
import mx_graalpython_benchmark
@@ -280,7 +280,7 @@ def libpythonvm_build_args():
280280
try:
281281
profile = cmd([])
282282
except BaseException:
283-
pass
283+
mx.log(f"Not using any PGO profile")
284284
else:
285285
mx.log(f"Using PGO profile {profile}")
286286
build_args += [
@@ -1072,7 +1072,7 @@ def is_included(path):
10721072

10731073
def run_python_unittests(python_binary, args=None, paths=None, exclude=None, env=None,
10741074
use_pytest=False, cwd=None, lock=None, out=None, err=None, nonZeroIsFatal=True, timeout=None,
1075-
report=False, parallel=None, runner_args=None):
1075+
report: Union[Task, bool, None] = False, parallel=None, runner_args=None):
10761076
if lock:
10771077
lock.acquire()
10781078

@@ -1148,7 +1148,7 @@ def run_python_unittests(python_binary, args=None, paths=None, exclude=None, env
11481148
return result
11491149

11501150

1151-
def run_hpy_unittests(python_binary, args=None, env=None, nonZeroIsFatal=True, timeout=None, report=False):
1151+
def run_hpy_unittests(python_binary, args=None, env=None, nonZeroIsFatal=True, timeout=None, report: Union[Task, bool, None] = False):
11521152
t0 = time.time()
11531153
result = downstream_tests.downstream_test_hpy(python_binary, args=args, env=env, check=nonZeroIsFatal, timeout=timeout)
11541154
if report:
@@ -1160,7 +1160,7 @@ def run_hpy_unittests(python_binary, args=None, env=None, nonZeroIsFatal=True, t
11601160

11611161

11621162
def run_tagged_unittests(python_binary, env=None, cwd=None, nonZeroIsFatal=True, checkIfWithGraalPythonEE=False,
1163-
report=False, parallel=8, exclude=None, paths=()):
1163+
report: Union[Task, bool, None] = False, parallel=8, exclude=None, paths=()):
11641164

11651165
if checkIfWithGraalPythonEE:
11661166
mx.run([python_binary, "-c", "import sys; print(sys.version)"])
@@ -1432,13 +1432,13 @@ def graalpython_gate_runner(args, tasks):
14321432
if task:
14331433
run_mx([
14341434
"--dy", "graalpython,/substratevm",
1435-
"-p", os.path.join(mx.suite("truffle"), "..", "vm"),
1435+
"-p", os.path.join(mx.suite("truffle").dir, "..", "vm"),
14361436
"--native-images=",
14371437
"build",
14381438
], env={**os.environ, **LATEST_JAVA_HOME})
14391439
run_mx([
14401440
"--dy", "graalpython,/substratevm",
1441-
"-p", os.path.join(mx.suite("truffle"), "..", "vm"),
1441+
"-p", os.path.join(mx.suite("truffle").dir, "..", "vm"),
14421442
"--native-images=",
14431443
"gate", "svm-truffle-tck-python",
14441444
])

0 commit comments

Comments
 (0)