rename function

timfel · timfel · commit b3980302ae07 · 2018-09-07T09:33:52.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/expression/ExpressionNode.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/expression/ExpressionNode.java
@@ -145,7 +145,7 @@ public boolean hasSideEffectAsAnExpression() {
         }
     }
 
-    public final ExpressionNode withSideEffects(StatementNode sideEffect) {
+    public final ExpressionNode withSideEffect(StatementNode sideEffect) {
         return new ExpressionWithSideEffects(this, sideEffect);
     }
 }
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/parser/PythonTreeTranslator.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/parser/PythonTreeTranslator.java
@@ -983,7 +983,7 @@ public Object visitComparison(Python3Parser.ComparisonContext ctx) {
             } else {
                 ReadNode tempVar = environment.makeTempLocalVariable();
                 StatementNode tempAsgn = tempVar.makeWriteNode(rhs);
-                nextComp = factory.createComparisonOperation(op, lhs, (ExpressionNode) tempVar).withSideEffects(tempAsgn);
+                nextComp = factory.createComparisonOperation(op, lhs, (ExpressionNode) tempVar).withSideEffect(tempAsgn);
                 lhs = (ExpressionNode) tempVar;
             }
             if (currentComparison == null) {

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public boolean hasSideEffectAsAnExpression() {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`- public final ExpressionNode withSideEffects(StatementNode sideEffect) {`
	`148`	`+ public final ExpressionNode withSideEffect(StatementNode sideEffect) {`
`149`	`149`	`return new ExpressionWithSideEffects(this, sideEffect);`
`150`	`150`	`}`
`151`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -983,7 +983,7 @@ public Object visitComparison(Python3Parser.ComparisonContext ctx) {`
`983`	`983`	`} else {`
`984`	`984`	`ReadNode tempVar = environment.makeTempLocalVariable();`
`985`	`985`	`StatementNode tempAsgn = tempVar.makeWriteNode(rhs);`
`986`		`- nextComp = factory.createComparisonOperation(op, lhs, (ExpressionNode) tempVar).withSideEffects(tempAsgn);`
	`986`	`+ nextComp = factory.createComparisonOperation(op, lhs, (ExpressionNode) tempVar).withSideEffect(tempAsgn);`
`987`	`987`	`lhs = (ExpressionNode) tempVar;`
`988`	`988`	`}`
`989`	`989`	`if (currentComparison == null) {`