slightly improve class access

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/object/GetClassNode.java

@@ -68,11 +68,25 @@
 @TypeSystemReference(PythonTypes.class)
 @ImportStatic({PGuards.class})
 public abstract class GetClassNode extends PNodeWithContext {
+    private final ValueProfile classProfile = ValueProfile.createClassProfile();
+
     public static GetClassNode create() {
         return GetClassNodeGen.create();
     }
 
-    public abstract PythonClass execute(Object object);
+    public abstract PythonClass execute(boolean object);
+
+    public abstract PythonClass execute(int object);
+
+    public abstract PythonClass execute(long object);
+
+    public abstract PythonClass execute(double object);
+
+    public final PythonClass execute(Object object) {
+        return executeGetClass(classProfile.profile(object));
+    }
+
+    public abstract PythonClass executeGetClass(Object object);
 
     @Specialization(assumptions = "singleContextAssumption()")
     protected PythonClass getIt(@SuppressWarnings("unused") GetSetDescriptor object,
@@ -191,23 +205,7 @@ protected PythonClass getIt(PythonNativeObject object,
         return getNativeClassNode.execute(object);
     }
 
-    @SuppressWarnings("unchecked")
-    protected Class<? extends PythonObject> asPythonObjectSubclass(Class<? extends Object> clazz) {
-        Class<? extends PythonObject> retval = null;
-        if (PythonObject.class.isAssignableFrom(clazz)) {
-            retval = (Class<? extends PythonObject>) clazz;
-        }
-        return retval;
-    }
-
-    @Specialization(guards = {"object.getClass() == cachedClass"}, limit = "5")
-    protected PythonClass getPythonClassCached(Object object,
-                    @Cached("asPythonObjectSubclass(object.getClass())") Class<? extends PythonObject> cachedClass,
-                    @Cached("createIdentityProfile()") ValueProfile profile) {
-        return profile.profile(cachedClass.cast(object).getPythonClass());
-    }
-
-    @Specialization(replaces = "getPythonClassCached")
+    @Specialization
     protected PythonClass getPythonClassGeneric(PythonObject object,
                     @Cached("createIdentityProfile()") ValueProfile profile) {
         return profile.profile(object.getPythonClass());

mx.graalpython/mx_graalpython_bench_param.py

@@ -72,6 +72,7 @@
     'boolean-logic': ITER_15 + ['1000'],
     'builtin-len-tuple': ITER_10 + [],
     'builtin-len': ITER_25 + [],
+    'class_access': ITER_25 + ['50000'],
     'call-method-polymorphic': ITER_10 + ['1000'],
     'for-range': ITER_25 + ['50000'],
     'function-call': ITER_25 + [],