Remove method 'SequenceStorage.append'.

Author: fangerer

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/runtime/SequenceStorageTests.java

@@ -101,14 +101,6 @@ public void objectsInsert() {
         assertEquals(7, store.length());
     }
 
-    @Test
-    public void objectAppend() {
-        ObjectSequenceStorage store = new ObjectSequenceStorage(getObjectValues());
-        store.append(42);
-        assertEquals(42, store.getItemNormalized(6));
-        assertEquals(7, store.length());
-    }
-
     /**
      * IntSequenceStorage tests.
      */
@@ -167,13 +159,4 @@ public void intInsert() throws SequenceStoreException {
         assertEquals(6, store.getItemNormalized(6));
         assertEquals(7, store.length());
     }
-
-    @Test
-    public void intAppend() throws SequenceStoreException {
-        IntSequenceStorage store = new IntSequenceStorage(getIntValues());
-        store.append(42);
-        assertEquals(42, store.getItemNormalized(6));
-        assertEquals(7, store.length());
-    }
-
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/BoolSequenceStorage.java

@@ -280,15 +280,6 @@ public int indexOfBool(boolean value) {
         return -1;
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        if (value instanceof Boolean) {
-            appendBool((boolean) value);
-        } else {
-            throw new SequenceStoreException(value);
-        }
-    }
-
     public void appendBool(boolean value) {
         ensureCapacity(length + 1);
         values[length] = value;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/ByteSequenceStorage.java

@@ -31,7 +31,6 @@
 import java.util.Arrays;
 
 import com.oracle.graal.python.PythonLanguage;
-import com.oracle.graal.python.builtins.objects.ints.PInt;
 import com.oracle.graal.python.runtime.sequence.SequenceUtil;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 
@@ -378,25 +377,6 @@ public int indexOfInt(int value) {
         return -1;
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        if (value instanceof Integer) {
-            appendInt((int) value);
-        } else if (value instanceof Long) {
-            appendLong((long) value);
-        } else if (value instanceof PInt) {
-            try {
-                appendInt(((PInt) value).intValueExact());
-            } catch (ArithmeticException e) {
-                throw new SequenceStoreException(value);
-            }
-        } else if (value instanceof Byte) {
-            appendByte((byte) value);
-        } else {
-            throw new SequenceStoreException(value);
-        }
-    }
-
     public void appendLong(long value) {
         if (value < 0 || value >= 256) {
             throw new SequenceStoreException(value);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/CharSequenceStorage.java

@@ -139,11 +139,6 @@ public int index(Object value) {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public void reverse() {
         throw new UnsupportedOperationException();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/DoubleSequenceStorage.java

@@ -283,15 +283,6 @@ public int indexOfDouble(double value) {
         return -1;
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        if (value instanceof Double) {
-            appendDouble((double) value);
-        } else {
-            throw new SequenceStoreException(value);
-        }
-    }
-
     public void appendDouble(double value) {
         ensureCapacity(length + 1);
         values[length] = value;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/EmptySequenceStorage.java

@@ -156,11 +156,6 @@ public Object popInBound(int idx) {
         return new UnsupportedOperationException();
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        throw new SequenceStoreException(value);
-    }
-
     @Override
     public void reverse() {
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/IntSequenceStorage.java

@@ -287,15 +287,6 @@ public int indexOfInt(int value) {
         return -1;
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        if (value instanceof Integer) {
-            appendInt((int) value);
-        } else {
-            throw new SequenceStoreException(value);
-        }
-    }
-
     public void appendInt(int value) {
         ensureCapacity(length + 1);
         values[length] = value;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/ListSequenceStorage.java

@@ -313,21 +313,6 @@ public int indexOfList(PList value) {
         return -1;
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        if (value instanceof PList) {
-            SequenceStorage list = ((PList) value).getSequenceStorage();
-            if (list instanceof ListSequenceStorage && ((ListSequenceStorage) list).getKind() == kind)
-                appendList((PList) value);
-            else if (list.getClass() == kind)
-                appendList((PList) value);
-            else
-                throw new SequenceStoreException(value);
-        } else
-            throw new SequenceStoreException(value);
-
-    }
-
     public void appendList(PList value) {
         ensureCapacity(length + 1);
         values[length] = value;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/LongSequenceStorage.java

@@ -295,18 +295,6 @@ public int indexOfLong(long value) {
         return -1;
     }
 
-    @Override
-    public void append(Object val) throws SequenceStoreException {
-        Object value = (val instanceof Integer) ? BigInteger.valueOf((int) val).longValue() : val;
-        value = (val instanceof BigInteger) ? ((BigInteger) val).longValue() : value;
-
-        if (value instanceof Long) {
-            appendLong((long) value);
-        } else {
-            throw new SequenceStoreException(value);
-        }
-    }
-
     public void appendLong(long value) {
         ensureCapacity(length + 1);
         values[length] = value;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/NativeSequenceStorage.java

@@ -174,11 +174,6 @@ public Object popInBound(int idx) {
         throw new AssertionError("should not reach");
     }
 
-    @Override
-    public void append(Object value) throws SequenceStoreException {
-        throw new AssertionError("should not reach");
-    }
-
     @Override
     public void reverse() {
         throw new AssertionError("should not reach");