Fixed NaN handling in float() constructor to support subclasses

Author: otethal

graalpython/com.oracle.graal.python.test/src/tests/test_float.py

@@ -879,3 +879,8 @@ def test_short_repr(self):
             # Since Python 3.2, repr and str are identical
             self.assertEqual(repr(float(s)), str(float(s)))
             self.assertEqual(repr(float(negs)), str(float(negs)))
+
+
+class SubclassTests(unittest.TestCase):
+    def test_subclass_nan(self):
+        self.assertEqual(MyFloat, type(MyFloat('nan')))

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -778,7 +778,6 @@ public abstract static class FloatNode extends PythonBinaryBuiltinNode {
         @Child private LookupAndCallUnaryNode callReprNode;
 
         @Child private IsBuiltinClassProfile isPrimitiveProfile = IsBuiltinClassProfile.create();
-        private ConditionProfile isNanProfile;
 
         public abstract Object executeWith(VirtualFrame frame, Object cls, Object arg);
 
@@ -828,7 +827,7 @@ Object floatFromDouble(Object cls, double arg) {
             if (isPrimitiveFloat(cls)) {
                 return arg;
             }
-            return factoryCreateFloat(cls, arg);
+            return factory().createFloat(cls, arg);
         }
 
         @Specialization(guards = "!isNativeClass(cls)")
@@ -837,7 +836,7 @@ Object floatFromString(VirtualFrame frame, Object cls, String arg) {
             if (isPrimitiveFloat(cls)) {
                 return value;
             }
-            return factoryCreateFloat(cls, value);
+            return factory().createFloat(cls, value);
         }
 
         private double convertBytesToDouble(VirtualFrame frame, PBytesLike arg) {
@@ -980,21 +979,6 @@ private byte[] getByteArray(VirtualFrame frame, PBytesLike pByteArray) {
             }
             return toByteArrayNode.execute(frame, pByteArray);
         }
-
-        private PFloat factoryCreateFloat(Object cls, double arg) {
-            if (isNaN(arg)) {
-                return getCore().getNaN();
-            }
-            return factory().createFloat(cls, arg);
-        }
-
-        private boolean isNaN(double d) {
-            if (isNanProfile == null) {
-                CompilerDirectives.transferToInterpreterAndInvalidate();
-                isNanProfile = ConditionProfile.createBinaryProfile();
-            }
-            return isNanProfile.profile(Double.isNaN(d));
-        }
     }
 
     // frozenset([iterable])