Skip to content

Commit b94eb11

Browse files
msimacekmsimacek
committed
Add PyFloatAsDoubleNode
1 parent 90c75b7 commit b94eb11

File tree

2 files changed

+157
-1
lines changed

2 files changed

+157
-1
lines changed

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyFloatAsDoubleNode.java

Lines changed: 156 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,156 @@
1+
/*
2+
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
41+
package com.oracle.graal.python.lib;
42+
43+
import static com.oracle.graal.python.builtins.PythonBuiltinClassType.DeprecationWarning;
44+
import static com.oracle.graal.python.builtins.PythonBuiltinClassType.TypeError;
45+
import static com.oracle.graal.python.nodes.SpecialMethodNames.__FLOAT__;
46+
47+
import com.oracle.graal.python.builtins.PythonBuiltinClassType;
48+
import com.oracle.graal.python.builtins.modules.WarningsModuleBuiltins;
49+
import com.oracle.graal.python.builtins.objects.PNone;
50+
import com.oracle.graal.python.builtins.objects.cext.PythonAbstractNativeObject;
51+
import com.oracle.graal.python.builtins.objects.floats.PFloat;
52+
import com.oracle.graal.python.builtins.objects.ints.PInt;
53+
import com.oracle.graal.python.nodes.ErrorMessages;
54+
import com.oracle.graal.python.nodes.PGuards;
55+
import com.oracle.graal.python.nodes.PNodeWithContext;
56+
import com.oracle.graal.python.nodes.PRaiseNode;
57+
import com.oracle.graal.python.nodes.call.special.CallUnaryMethodNode;
58+
import com.oracle.graal.python.nodes.call.special.LookupSpecialMethodNode;
59+
import com.oracle.graal.python.nodes.classes.IsSubtypeNode;
60+
import com.oracle.graal.python.nodes.object.GetClassNode;
61+
import com.oracle.graal.python.nodes.object.IsBuiltinClassProfile;
62+
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
63+
import com.oracle.truffle.api.dsl.Bind;
64+
import com.oracle.truffle.api.dsl.Cached;
65+
import com.oracle.truffle.api.dsl.GenerateUncached;
66+
import com.oracle.truffle.api.dsl.ImportStatic;
67+
import com.oracle.truffle.api.dsl.Specialization;
68+
import com.oracle.truffle.api.frame.Frame;
69+
import com.oracle.truffle.api.frame.VirtualFrame;
70+
71+
/**
72+
* Equivalent of CPython's {@code PyFloat_AsDouble}. Converts the argument to a Java {@code double}
73+
* using its {@code __float__} special method. If not available, falls back to {@code __index__}
74+
* special method. Otherwise, raises {@code TypeError}. Can raise {@code OverflowError} when using
75+
* {@code __index__} and the returned integer wouldn't fit into double.
76+
*/
77+
@GenerateUncached
78+
@ImportStatic({PGuards.class, PythonBuiltinClassType.class})
79+
public abstract class PyFloatAsDoubleNode extends PNodeWithContext {
80+
public abstract double execute(Frame frame, Object object);
81+
82+
@Specialization
83+
double doDouble(double object) {
84+
return object;
85+
}
86+
87+
@Specialization
88+
double doPFloat(PFloat object) {
89+
return object.getValue();
90+
}
91+
92+
@Specialization
93+
double doInt(int object) {
94+
return object;
95+
}
96+
97+
@Specialization
98+
double doLong(long object) {
99+
return object;
100+
}
101+
102+
@Specialization
103+
double doPInt(PInt object,
104+
@Cached PRaiseNode raiseNode) {
105+
return object.doubleValueWithOverflow(raiseNode);
106+
}
107+
108+
@Specialization
109+
double doBoolean(boolean object) {
110+
return object ? 1.0 : 0.0;
111+
}
112+
113+
@Specialization(guards = {"!isDouble(object)", "!isPFloat(object)", "!canBeInteger(object)", "!isNativeObject(object) || isSubtypeNode.execute(type, PFloat)"}, limit = "1")
114+
double doObject(VirtualFrame frame, Object object,
115+
@SuppressWarnings("unused") @Cached GetClassNode getClassNode,
116+
@SuppressWarnings("unused") @Cached IsSubtypeNode isSubtypeNode,
117+
@Bind("getClassNode.execute(object)") Object type,
118+
@Cached LookupSpecialMethodNode.Dynamic lookup,
119+
@Cached CallUnaryMethodNode call,
120+
@Cached GetClassNode resultClassNode,
121+
@Cached IsBuiltinClassProfile resultProfile,
122+
@Cached IsSubtypeNode resultSubtypeNode,
123+
@Cached PyIndexCheckNode indexCheckNode,
124+
@Cached PyNumberIndexNode indexNode,
125+
@Cached PyFloatAsDoubleNode recursive,
126+
@Cached WarningsModuleBuiltins.WarnNode warnNode,
127+
@Cached PRaiseNode raiseNode) {
128+
Object floatDescr = lookup.execute(frame, type, object, __FLOAT__, false);
129+
if (floatDescr != PNone.NO_VALUE) {
130+
Object result = call.executeObject(frame, floatDescr, object);
131+
Object resultType = resultClassNode.execute(result);
132+
if (!resultProfile.profileClass(resultType, PythonBuiltinClassType.PFloat)) {
133+
if (!resultSubtypeNode.execute(resultType, PythonBuiltinClassType.PFloat)) {
134+
throw raiseNode.raise(TypeError, ErrorMessages.RETURNED_NON_FLOAT, object, result);
135+
} else {
136+
warnNode.warnFormat(frame, null, DeprecationWarning, 1,
137+
ErrorMessages.WARN_P_RETURNED_NON_P, object, __FLOAT__, "float", result, "float");
138+
}
139+
}
140+
return recursive.execute(frame, result);
141+
}
142+
if (indexCheckNode.execute(object)) {
143+
Object index = indexNode.execute(frame, object);
144+
return recursive.execute(frame, index);
145+
}
146+
throw raiseNode.raise(TypeError, ErrorMessages.MUST_BE_REAL_NUMBER, object);
147+
}
148+
149+
@Specialization(guards = "isSubtypeNode.execute(getClassNode.execute(object), PFloat)", limit = "1")
150+
@TruffleBoundary
151+
double doNativeObject(@SuppressWarnings("unused") PythonAbstractNativeObject object,
152+
@SuppressWarnings("unused") @Cached GetClassNode getClassNode,
153+
@SuppressWarnings("unused") @Cached IsSubtypeNode isSubtypeNode) {
154+
throw new RuntimeException("casting a native float object to a Java double is not implemented yet");
155+
}
156+
}

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/classes/IsSubtypeNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ boolean issubTypeGeneric(Object derived, Object cls,
278278

279279
@Specialization(guards = {"!libD.isLazyPythonClass(derived) || !libC.isLazyPythonClass(cls)"})
280280
@Megamorphic
281-
public boolean fallback(VirtualFrame frame, Object derived, Object cls,
281+
boolean fallback(VirtualFrame frame, Object derived, Object cls,
282282
@SuppressWarnings("unused") @CachedLibrary(limit = "3") PythonObjectLibrary libD,
283283
@SuppressWarnings("unused") @CachedLibrary(limit = "3") PythonObjectLibrary libC,
284284
@Cached AbstractObjectGetBasesNode getBasesNode,

0 commit comments

Comments
 (0)