Skip to content

Commit ba6c31f

Browse files
committed
Remove unchecked cast
1 parent 97f23a2 commit ba6c31f

File tree

11 files changed

+47
-49
lines changed

11 files changed

+47
-49
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ReadlineModuleBuiltins.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public void postInitialize(Python3Core core) {
106106
abstract static class GetCompleterNode extends PythonUnaryBuiltinNode {
107107
@Specialization
108108
static Object getCompleter(PythonModule self) {
109-
LocalData data = self.getModuleState();
109+
LocalData data = self.getModuleState(LocalData.class);
110110
if (data.completer != null) {
111111
return data.completer;
112112
} else {
@@ -120,7 +120,7 @@ static Object getCompleter(PythonModule self) {
120120
abstract static class SetCompleterNode extends PythonBinaryBuiltinNode {
121121
@Specialization
122122
PNone setCompleter(PythonModule self, Object callable) {
123-
LocalData data = self.getModuleState();
123+
LocalData data = self.getModuleState(LocalData.class);
124124
data.completer = callable;
125125
return PNone.NONE;
126126
}
@@ -134,7 +134,7 @@ abstract static class ParseAndBindNode extends PythonBinaryBuiltinNode {
134134
PNone setCompleter(PythonModule self, TruffleString tspec) {
135135
String spec = tspec.toJavaStringUncached();
136136
if (spec.startsWith("tab:")) {
137-
LocalData data = self.getModuleState();
137+
LocalData data = self.getModuleState(LocalData.class);
138138
data.bindings.put("tab", spec.split(":")[1].trim());
139139
return PNone.NONE;
140140
} else {
@@ -159,7 +159,7 @@ abstract static class GetHistoryLengthNode extends PythonUnaryBuiltinNode {
159159
@Specialization
160160
@TruffleBoundary
161161
int setCompleter(PythonModule self) {
162-
LocalData data = self.getModuleState();
162+
LocalData data = self.getModuleState(LocalData.class);
163163
return data.history.size();
164164
}
165165
}
@@ -170,7 +170,7 @@ abstract static class SetHistoryLengthNode extends PythonBinaryBuiltinNode {
170170
@Specialization
171171
@TruffleBoundary
172172
TruffleString setCompleter(PythonModule self, int index) {
173-
LocalData data = self.getModuleState();
173+
LocalData data = self.getModuleState(LocalData.class);
174174
try {
175175
return data.history.get(index);
176176
} catch (IndexOutOfBoundsException e) {
@@ -192,7 +192,7 @@ TruffleString setCompleter(PythonModule self, int index, PString string,
192192
@Specialization
193193
@TruffleBoundary
194194
TruffleString setCompleter(PythonModule self, int index, TruffleString string) {
195-
LocalData data = self.getModuleState();
195+
LocalData data = self.getModuleState(LocalData.class);
196196
try {
197197
return data.history.set(index, string);
198198
} catch (IndexOutOfBoundsException e) {
@@ -207,7 +207,7 @@ abstract static class DeleteItemNode extends PythonBinaryBuiltinNode {
207207
@Specialization
208208
@TruffleBoundary
209209
TruffleString setCompleter(PythonModule self, int index) {
210-
LocalData data = self.getModuleState();
210+
LocalData data = self.getModuleState(LocalData.class);
211211
try {
212212
return data.history.remove(index);
213213
} catch (IndexOutOfBoundsException e) {
@@ -229,7 +229,7 @@ static PNone addHistory(PythonModule self, PString item,
229229
@Specialization
230230
@TruffleBoundary
231231
static PNone addHistory(PythonModule self, TruffleString item) {
232-
LocalData data = self.getModuleState();
232+
LocalData data = self.getModuleState(LocalData.class);
233233
data.history.add(item);
234234
return PNone.NONE;
235235
}
@@ -249,7 +249,7 @@ PNone setCompleter(PythonModule self, PString path,
249249
@TruffleBoundary
250250
@SuppressWarnings("try")
251251
PNone setCompleter(PythonModule self, TruffleString path) {
252-
LocalData data = self.getModuleState();
252+
LocalData data = self.getModuleState(LocalData.class);
253253
try (GilNode.UncachedRelease gil = GilNode.uncachedRelease()) {
254254
BufferedReader reader = getContext().getEnv().getPublicTruffleFile(path.toJavaStringUncached()).newBufferedReader();
255255
String line;
@@ -277,7 +277,7 @@ PNone setCompleter(PythonModule self, PString path,
277277
@Specialization
278278
@TruffleBoundary
279279
PNone setCompleter(PythonModule self, TruffleString path) {
280-
LocalData data = self.getModuleState();
280+
LocalData data = self.getModuleState(LocalData.class);
281281
try {
282282
BufferedWriter writer = getContext().getEnv().getPublicTruffleFile(path.toJavaStringUncached()).newBufferedWriter(StandardOpenOption.CREATE, StandardOpenOption.TRUNCATE_EXISTING);
283283
for (TruffleString l : data.history) {
@@ -298,7 +298,7 @@ abstract static class ClearNode extends PythonUnaryBuiltinNode {
298298
@Specialization
299299
@TruffleBoundary
300300
static PNone setCompleter(PythonModule self) {
301-
LocalData data = self.getModuleState();
301+
LocalData data = self.getModuleState(LocalData.class);
302302
data.history.clear();
303303
return PNone.NONE;
304304
}
@@ -327,7 +327,7 @@ static PNone setCompleter() {
327327
abstract static class GetAutoHistoryNode extends PythonUnaryBuiltinNode {
328328
@Specialization
329329
static boolean setCompleter(PythonModule self) {
330-
LocalData data = self.getModuleState();
330+
LocalData data = self.getModuleState(LocalData.class);
331331
return data.autoHistory;
332332
}
333333
}
@@ -337,7 +337,7 @@ static boolean setCompleter(PythonModule self) {
337337
abstract static class SetAutoHistoryNode extends PythonBinaryBuiltinNode {
338338
@Specialization
339339
static PNone setCompleter(PythonModule self, boolean enabled) {
340-
LocalData data = self.getModuleState();
340+
LocalData data = self.getModuleState(LocalData.class);
341341
data.autoHistory = enabled;
342342
return PNone.NONE;
343343
}
@@ -348,7 +348,7 @@ static PNone setCompleter(PythonModule self, boolean enabled) {
348348
abstract static class SetCompleterDelimsNode extends PythonBinaryBuiltinNode {
349349
@Specialization
350350
static PNone setCompleterDelims(PythonModule self, TruffleString completerDelims) {
351-
LocalData data = self.getModuleState();
351+
LocalData data = self.getModuleState(LocalData.class);
352352
data.completerDelims = completerDelims;
353353
return PNone.NONE;
354354
}
@@ -359,7 +359,7 @@ static PNone setCompleterDelims(PythonModule self, TruffleString completerDelims
359359
abstract static class GetCompleterDelimsNode extends PythonBuiltinNode {
360360
@Specialization
361361
static Object getCompleterDelims(PythonModule self) {
362-
LocalData data = self.getModuleState();
362+
LocalData data = self.getModuleState(LocalData.class);
363363
return (data.completerDelims != null) ? data.completerDelims : PNone.NONE;
364364
}
365365
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SignalModuleBuiltins.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public void postInitialize(Python3Core core) {
160160
}
161161

162162
public static void resetSignalHandlers(PythonModule mod) {
163-
ModuleData data = mod.getModuleState();
163+
ModuleData data = mod.getModuleState(ModuleData.class);
164164
if (data != null) {
165165
for (Map.Entry<Integer, SignalHandler> entry : data.defaultSignalHandlers.entrySet()) {
166166
Signals.setSignalHandler(entry.getKey(), entry.getValue());
@@ -227,7 +227,7 @@ abstract static class AlarmNode extends PythonBinaryClinicBuiltinNode {
227227
@TruffleBoundary
228228
int alarm(PythonModule module, int seconds) {
229229
int remaining = 0;
230-
ModuleData data = module.getModuleState();
230+
ModuleData data = module.getModuleState(ModuleData.class);
231231
Signals.Alarm currentAlarm = data.currentAlarm;
232232
if (currentAlarm != null) {
233233
if (currentAlarm.isRunning()) {
@@ -277,7 +277,7 @@ abstract static class GetSignalNode extends PythonBinaryClinicBuiltinNode {
277277
@Specialization
278278
@TruffleBoundary
279279
static Object getsignal(PythonModule mod, int signum) {
280-
ModuleData data = mod.getModuleState();
280+
ModuleData data = mod.getModuleState(ModuleData.class);
281281
return handlerToPython(Signals.getCurrentSignalHandler(signum), signum, data);
282282
}
283283

@@ -305,7 +305,7 @@ abstract static class SignalNode extends PythonTernaryBuiltinNode {
305305
@TruffleBoundary
306306
static Object signalHandler(PythonModule self, Object signal, Object handler,
307307
@Bind("this") Node inliningTarget) {
308-
ModuleData data = self.getModuleState();
308+
ModuleData data = self.getModuleState(ModuleData.class);
309309
int signum = PyNumberAsSizeNode.executeExactUncached(signal);
310310
if (PyCallableCheckNode.executeUncached(handler)) {
311311
return signal(inliningTarget, signum, handler, data);
@@ -424,7 +424,7 @@ Object doIt(VirtualFrame frame, PythonModule self, int which, Object seconds, Ob
424424
@Cached PyTimeFromObjectNode timeFromObjectNode,
425425
@Cached PConstructAndRaiseNode.Lazy constructAndRaiseNode,
426426
@Cached PythonObjectFactory factory) {
427-
ModuleData moduleData = self.getModuleState();
427+
ModuleData moduleData = self.getModuleState(ModuleData.class);
428428
long usDelay = toMicroseconds(frame, inliningTarget, seconds, timeFromObjectNode);
429429
long usInterval = toMicroseconds(frame, inliningTarget, interval, timeFromObjectNode);
430430
if (which != ITIMER_REAL) {
@@ -492,7 +492,7 @@ static Object doIt(VirtualFrame frame, PythonModule self, int which,
492492
@Bind("this") Node inliningTarget,
493493
@Cached PConstructAndRaiseNode.Lazy constructAndRaiseNode,
494494
@Cached PythonObjectFactory factory) {
495-
ModuleData moduleData = self.getModuleState();
495+
ModuleData moduleData = self.getModuleState(ModuleData.class);
496496
if (which != ITIMER_REAL) {
497497
throw constructAndRaiseNode.get(inliningTarget).raiseOSError(frame, OSErrorEnum.EINVAL);
498498
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SocketModuleBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public Object varArgExecute(VirtualFrame frame, Object self, Object[] arguments,
231231
public abstract static class GetDefaultTimeoutNode extends PythonUnaryBuiltinNode {
232232
@Specialization
233233
static Object get(PythonModule module) {
234-
long timeout = module.getModuleState();
234+
long timeout = module.getModuleState(Long.class);
235235
return timeout < 0 ? PNone.NONE : TimeUtils.pyTimeAsSecondsDouble(timeout);
236236
}
237237
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ThreadModuleBuiltins.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ abstract static class GetThreadCountNode extends PythonUnaryBuiltinNode {
177177
@Specialization
178178
@TruffleBoundary
179179
long getCount(PythonModule self) {
180-
return self.<Integer> getModuleState();
180+
return self.getModuleState(Integer.class);
181181
}
182182
}
183183

@@ -230,7 +230,7 @@ long start(VirtualFrame frame, Object cls, Object callable, Object args, Object
230230
TruffleThreadBuilder threadBuilder = env.newTruffleThreadBuilder(() -> {
231231
try (GilNode.UncachedAcquire gil = GilNode.uncachedAcquire()) {
232232
// the increment is protected by the gil
233-
int curCount = threadModule.getModuleState();
233+
int curCount = threadModule.getModuleState(Integer.class);
234234
threadModule.setModuleState(curCount + 1);
235235
try {
236236
// n.b.: It is important to pass 'null' frame here because each thread has
@@ -246,7 +246,7 @@ long start(VirtualFrame frame, Object cls, Object callable, Object args, Object
246246
}
247247
// SystemExit is silently ignored (see _threadmodule.c: thread_run)
248248
} finally {
249-
curCount = threadModule.getModuleState();
249+
curCount = threadModule.getModuleState(Integer.class);
250250
threadModule.setModuleState(curCount - 1);
251251
}
252252
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/TimeModuleBuiltins.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ static PTuple localtime(VirtualFrame frame, PythonModule module, Object seconds,
339339
@Bind("this") Node inliningTarget,
340340
@Cached ToLongTime toLongTime,
341341
@Cached PythonObjectFactory factory) {
342-
ModuleState moduleState = module.getModuleState();
342+
ModuleState moduleState = module.getModuleState(ModuleState.class);
343343
return factory.createStructSeq(STRUCT_TIME_DESC, getTimeStruct(moduleState.currentZoneId, toLongTime.execute(frame, inliningTarget, seconds)));
344344
}
345345
}
@@ -440,7 +440,7 @@ abstract static class ProcessTimeNode extends PythonBuiltinNode {
440440
@Specialization
441441
@TruffleBoundary
442442
Object getProcesTime(PythonModule self) {
443-
ModuleState moduleState = self.getModuleState();
443+
ModuleState moduleState = self.getModuleState(ModuleState.class);
444444
return (System.nanoTime() - PythonContext.get(this).getPerfCounterStart() - moduleState.timeSlept) / 1000_000_000.0;
445445
}
446446
}
@@ -452,7 +452,7 @@ abstract static class ProcessTimeNsNode extends PythonBuiltinNode {
452452
@Specialization
453453
@TruffleBoundary
454454
Object getProcesNsTime(PythonModule self) {
455-
ModuleState moduleState = self.getModuleState();
455+
ModuleState moduleState = self.getModuleState(ModuleState.class);
456456
return (System.nanoTime() - PythonContext.get(this).getPerfCounterStart() - moduleState.timeSlept);
457457
}
458458
}
@@ -497,7 +497,7 @@ Object sleep(PythonModule self, long seconds,
497497
doSleep(this, seconds, deadline);
498498
} finally {
499499
gil.acquire();
500-
ModuleState moduleState = self.getModuleState();
500+
ModuleState moduleState = self.getModuleState(ModuleState.class);
501501
moduleState.timeSlept = nanoTime() - t + moduleState.timeSlept;
502502
}
503503
PythonContext.triggerAsyncActions(this);
@@ -521,7 +521,7 @@ Object sleep(PythonModule self, double seconds,
521521
doSleep(this, seconds, deadline);
522522
} finally {
523523
gil.acquire();
524-
ModuleState moduleState = self.getModuleState();
524+
ModuleState moduleState = self.getModuleState(ModuleState.class);
525525
moduleState.timeSlept = nanoTime() - t + moduleState.timeSlept;
526526
}
527527
PythonContext.triggerAsyncActions(this);
@@ -933,7 +933,7 @@ static TruffleString formatTime(PythonModule module, TruffleString format, @Supp
933933
if (byteIndexOfCodePointNode.execute(format, 0, 0, format.byteLength(TS_ENCODING), TS_ENCODING) >= 0) {
934934
throw raiseNode.get(inliningTarget).raise(PythonBuiltinClassType.ValueError, ErrorMessages.EMBEDDED_NULL_CHARACTER);
935935
}
936-
ModuleState moduleState = module.getModuleState();
936+
ModuleState moduleState = module.getModuleState(ModuleState.class);
937937
return format(toJavaStringNode.execute(format), getIntLocalTimeStruct(moduleState.currentZoneId, (long) timeSeconds()), fromJavaStringNode);
938938
}
939939

@@ -985,7 +985,7 @@ static double mktime(VirtualFrame frame, PythonModule module, PTuple tuple,
985985
for (int i = 0; i < ELEMENT_COUNT; i++) {
986986
integers[i] = asSizeNode.executeExact(frame, inliningTarget, items[i]);
987987
}
988-
ModuleState moduleState = module.getModuleState();
988+
ModuleState moduleState = module.getModuleState(ModuleState.class);
989989
return op(moduleState.currentZoneId, integers);
990990
}
991991

@@ -1006,7 +1006,7 @@ public static TruffleString localtime(VirtualFrame frame, PythonModule module, O
10061006
@Bind("this") Node inliningTarget,
10071007
@Cached ToLongTime toLongTime,
10081008
@Cached TruffleString.FromJavaStringNode fromJavaStringNode) {
1009-
ModuleState moduleState = module.getModuleState();
1009+
ModuleState moduleState = module.getModuleState(ModuleState.class);
10101010
int[] tm = getIntLocalTimeStruct(moduleState.currentZoneId, toLongTime.execute(frame, inliningTarget, seconds));
10111011
return format(tm, fromJavaStringNode);
10121012
}
@@ -1032,7 +1032,7 @@ public abstract static class ASCTimeNode extends PythonBinaryBuiltinNode {
10321032
@Specialization
10331033
static TruffleString localtime(PythonModule module, @SuppressWarnings("unused") PNone time,
10341034
@Shared("js2ts") @Cached TruffleString.FromJavaStringNode fromJavaStringNode) {
1035-
ModuleState moduleState = module.getModuleState();
1035+
ModuleState moduleState = module.getModuleState(ModuleState.class);
10361036
return format(getIntLocalTimeStruct(moduleState.currentZoneId, (long) timeSeconds()), fromJavaStringNode);
10371037
}
10381038

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/WarningsModuleBuiltins.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -445,28 +445,28 @@ private PFrame getCallerFrame(VirtualFrame frame, int stackLevel) {
445445
* uncached.
446446
*/
447447
private static long getStateFiltersVersion(PythonModule warningsModule) {
448-
return warningsModule.<ModuleState> getModuleState().filtersVersion;
448+
return warningsModule.getModuleState(ModuleState.class).filtersVersion;
449449
}
450450

451451
/**
452452
* On fast path.
453453
*/
454454
private Object getStateFilters(PythonModule warningsModule) {
455-
return warningsModule.<ModuleState> getModuleState().filters;
455+
return warningsModule.getModuleState(ModuleState.class).filters;
456456
}
457457

458458
/**
459459
* On slow path.
460460
*/
461461
private static Object getStateOnceRegistry(PythonModule warningsModule) {
462-
return warningsModule.<ModuleState> getModuleState().onceRegistry;
462+
return warningsModule.getModuleState(ModuleState.class).onceRegistry;
463463
}
464464

465465
/**
466466
* On fast path.
467467
*/
468468
private Object getStateDefaultAction(PythonModule warningsModule) {
469-
return warningsModule.<ModuleState> getModuleState().defaultAction;
469+
return warningsModule.getModuleState(ModuleState.class).defaultAction;
470470
}
471471

472472
/**
@@ -572,8 +572,7 @@ private TruffleString getDefaultAction(VirtualFrame frame, PythonModule module)
572572
private TruffleString getFilter(VirtualFrame frame, PythonModule _warnings, Object category, Object text, int lineno, Object module, Object[] item) {
573573
Object filters = getWarningsAttr(frame, T_FILTERS);
574574
if (filters != null) {
575-
ModuleState moduleState = _warnings.getModuleState();
576-
moduleState.filters = filters;
575+
_warnings.getModuleState(ModuleState.class).filters = filters;
577576
} else {
578577
filters = getStateFilters(_warnings);
579578
}
@@ -1067,7 +1066,7 @@ protected ArgumentClinicProvider getArgumentClinic() {
10671066
abstract static class FiltersMutated extends PythonBuiltinNode {
10681067
@Specialization
10691068
static PNone mutate(PythonModule self) {
1070-
ModuleState moduleState = self.getModuleState();
1069+
ModuleState moduleState = self.getModuleState(ModuleState.class);
10711070
moduleState.filtersVersion++;
10721071
return PNone.NONE;
10731072
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ast/AstModuleBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ PythonObject generic(Object cls, @SuppressWarnings("unused") Object[] varargs, @
132132
}
133133

134134
private static AstState getAstState(PythonContext context) {
135-
return context.lookupBuiltinModule(T__AST).getModuleState();
135+
return context.lookupBuiltinModule(T__AST).getModuleState(AstState.class);
136136
}
137137

138138
@TruffleBoundary

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/functools/LruCacheWrapperBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ static Object lruCacheNew(VirtualFrame frame, Object type,
187187
obj.misses = obj.hits = 0;
188188
obj.maxsize = maxsize;
189189

190-
obj.kwdMark = PythonContext.get(inliningTarget).lookupBuiltinModule(T_FUNCTOOLS).getModuleState();
190+
obj.kwdMark = PythonContext.get(inliningTarget).lookupBuiltinModule(T_FUNCTOOLS).getModuleState(Object.class);
191191

192192
obj.cacheInfoType = cache_info_type;
193193
// obj.dict = null;

0 commit comments

Comments
 (0)