Skip to content

Commit bad6005

Browse files
committed
Make test_posix and test_subprocess run serially
1 parent 6e61685 commit bad6005

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

graalpython/com.oracle.graal.python.test/src/graalpytest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@
5757
# test_import tests various behaviors related to __pycache__ directory,
5858
# it can interfere with other tests that generate code
5959
'test_import',
60+
'test_subprocess',
61+
'test_posix',
6062
]
6163

6264

graalpython/lib-python/3/test/test_posix.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -811,7 +811,6 @@ def test_listdir_bytes_like(self):
811811
for name in names:
812812
self.assertIs(type(name), bytes)
813813

814-
@support.impl_detail("[GR-30188] interferes with other tests executed concurrently", graalvm=False)
815814
@unittest.skipUnless(posix.listdir in os.supports_fd,
816815
"test needs fd support for posix.listdir()")
817816
def test_listdir_fd(self):

graalpython/lib-python/3/test/test_subprocess.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2373,7 +2373,6 @@ def test_bytes_program(self):
23732373
exitcode = subprocess.call([program]+args, env=envb)
23742374
self.assertEqual(exitcode, 0)
23752375

2376-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
23772376
def test_pipe_cloexec(self):
23782377
sleeper = support.findfile("input_reader.py", subdir="subprocessdata")
23792378
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")
@@ -2439,7 +2438,6 @@ def kill_p2():
24392438
p1.stdout.close()
24402439
p2.stdout.close()
24412440

2442-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
24432441
def test_close_fds(self):
24442442
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")
24452443

@@ -2488,7 +2486,6 @@ def test_close_fds(self):
24882486
self.assertIn(1, remaining_fds, "Subprocess failed")
24892487

24902488

2491-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
24922489
@unittest.skipIf(sys.platform.startswith("freebsd") and
24932490
os.stat("/dev").st_dev == os.stat("/dev/fd").st_dev,
24942491
"Requires fdescfs mounted on /dev/fd on FreeBSD.")
@@ -2572,7 +2569,6 @@ def test_close_fds_when_max_fd_is_lowered(self):
25722569
# descriptor of a pipe closed in the parent process is valid in the
25732570
# child process according to fstat(), but the mode of the file
25742571
# descriptor is invalid, and read or write raise an error.
2575-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
25762572
@support.requires_mac_ver(10, 5)
25772573
def test_pass_fds(self):
25782574
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")
@@ -2607,7 +2603,6 @@ def test_pass_fds(self):
26072603
close_fds=False, pass_fds=(fd, )))
26082604
self.assertIn('overriding close_fds', str(context.warning))
26092605

2610-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
26112606
def test_pass_fds_inheritable(self):
26122607
script = support.findfile("fd_status.py", subdir="subprocessdata")
26132608

@@ -2638,7 +2633,6 @@ def test_pass_fds_inheritable(self):
26382633
# bpo-32270: Ensure that descriptors specified in pass_fds
26392634
# are inherited even if they are used in redirections.
26402635
# Contributed by @izbyshev.
2641-
@support.impl_detail("[GR-30188] may cause transient failures when executed concurrently", graalvm=False)
26422636
def test_pass_fds_redirected(self):
26432637
"""Regression test for https://bugs.python.org/issue32270."""
26442638
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")

0 commit comments

Comments
 (0)