Skip to content

Commit bd059f5

Browse files
committed
Do no longer skip multi-phase ext mod init test cases
1 parent 071f461 commit bd059f5

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

graalpython/lib-python/3/test/test_importlib/extension/test_loader.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def setUp(self):
104104
# Handling failure on reload is the up to the module.
105105
test_state_after_failure = None
106106

107-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
108107
def test_module(self):
109108
'''Test loading an extension module'''
110109
with util.uncache(self.name):
@@ -119,7 +118,6 @@ def test_module(self):
119118
self.assertIsInstance(module.__loader__,
120119
self.machinery.ExtensionFileLoader)
121120

122-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
123121
def test_functionality(self):
124122
'''Test basic functionality of stuff defined in an extension module'''
125123
with util.uncache(self.name):
@@ -140,7 +138,6 @@ def test_functionality(self):
140138
self.assertEqual(module.int_const, 1969)
141139
self.assertEqual(module.str_const, 'something different')
142140

143-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
144141
def test_reload(self):
145142
'''Test that reload didn't re-set the module's attributes'''
146143
with util.uncache(self.name):
@@ -149,7 +146,6 @@ def test_reload(self):
149146
importlib.reload(module)
150147
self.assertIs(ex_class, module.Example)
151148

152-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
153149
def test_try_registration(self):
154150
'''Assert that the PyState_{Find,Add,Remove}Module C API doesn't work'''
155151
module = self.load_module()
@@ -175,15 +171,13 @@ def load_module_by_name(self, fullname):
175171
loader.exec_module(module)
176172
return module
177173

178-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
179174
def test_load_submodule(self):
180175
'''Test loading a simulated submodule'''
181176
module = self.load_module_by_name('pkg.' + self.name)
182177
self.assertIsInstance(module, types.ModuleType)
183178
self.assertEqual(module.__name__, 'pkg.' + self.name)
184179
self.assertEqual(module.str_const, 'something different')
185180

186-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
187181
def test_load_short_name(self):
188182
'''Test loading module with a one-character name'''
189183
module = self.load_module_by_name('x')
@@ -192,7 +186,6 @@ def test_load_short_name(self):
192186
self.assertEqual(module.str_const, 'something different')
193187
self.assertNotIn('x', sys.modules)
194188

195-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
196189
def test_load_twice(self):
197190
'''Test that 2 loads result in 2 module objects'''
198191
module1 = self.load_module_by_name(self.name)
@@ -213,7 +206,6 @@ def test_unloadable_nonascii(self):
213206
self.load_module_by_name(name)
214207
self.assertEqual(cm.exception.name, name)
215208

216-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
217209
def test_nonmodule(self):
218210
'''Test returning a non-module object from create works'''
219211
name = self.name + '_nonmodule'
@@ -222,7 +214,6 @@ def test_nonmodule(self):
222214
self.assertEqual(mod.three, 3)
223215

224216
# issue 27782
225-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
226217
def test_nonmodule_with_methods(self):
227218
'''Test creating a non-module object with methods defined'''
228219
name = self.name + '_nonmodule_with_methods'
@@ -231,15 +222,13 @@ def test_nonmodule_with_methods(self):
231222
self.assertEqual(mod.three, 3)
232223
self.assertEqual(mod.bar(10, 1), 9)
233224

234-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
235225
def test_null_slots(self):
236226
'''Test that NULL slots aren't a problem'''
237227
name = self.name + '_null_slots'
238228
module = self.load_module_by_name(name)
239229
self.assertIsInstance(module, types.ModuleType)
240230
self.assertEqual(module.__name__, name)
241231

242-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
243232
def test_bad_modules(self):
244233
'''Test SystemError is raised for misbehaving extensions'''
245234
for name_base in [
@@ -264,7 +253,6 @@ def test_bad_modules(self):
264253
with self.assertRaises(SystemError):
265254
self.load_module_by_name(name)
266255

267-
@impl_detail("GR-26683 multi-phase init not supported", graalvm=False)
268256
def test_nonascii(self):
269257
'''Test that modules with non-ASCII names can be loaded'''
270258
# punycode behaves slightly differently in some-ASCII and no-ASCII

0 commit comments

Comments
 (0)