inline otherwise unused function

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/AbstractCallMethodNode.java

@@ -94,29 +94,6 @@ abstract class AbstractCallMethodNode extends PNodeWithContext {
 
     protected abstract void setMaxSizeExceeded(boolean value);
 
-    /**
-     * Returns a new instanceof the builtin if it's a subclass of the given class, and null
-     * otherwise.
-     */
-    private <T extends PythonBuiltinBaseNode> T getBuiltin(VirtualFrame frame, PBuiltinFunction func, Class<T> clazz) {
-        CompilerAsserts.neverPartOfCompilation();
-        NodeFactory<? extends PythonBuiltinBaseNode> builtinNodeFactory = func.getBuiltinNodeFactory();
-        if (builtinNodeFactory == null) {
-            return null; // see for example MethodDescriptorRoot and subclasses
-        }
-        assert builtinNodeFactory.getNodeClass().getAnnotationsByType(Builtin.class).length > 0 : "PBuiltinFunction " + func + " is expected to have a Builtin annotated node.";
-        if (builtinNodeFactory.getNodeClass().getAnnotationsByType(Builtin.class)[0].needsFrame() && frame == null) {
-            return null;
-        }
-        if (clazz.isAssignableFrom(builtinNodeFactory.getNodeClass())) {
-            T builtinNode = clazz.cast(func.getBuiltinNodeFactory().createNode());
-            if (!callerExceedsMaxSize(builtinNode)) {
-                return builtinNode;
-            }
-        }
-        return null;
-    }
-
     protected PythonBuiltinBaseNode getBuiltin(VirtualFrame frame, PBuiltinFunction func, int nargs) {
         CompilerAsserts.neverPartOfCompilation();
         NodeFactory<? extends PythonBuiltinBaseNode> builtinNodeFactory = func.getBuiltinNodeFactory();
@@ -225,8 +202,22 @@ protected static boolean frameIsUnused(PythonBuiltinBaseNode builtinNode) {
     }
 
     PythonVarargsBuiltinNode getVarargs(VirtualFrame frame, Object func) {
-        if (func instanceof PBuiltinFunction) {
-            return getBuiltin(frame, (PBuiltinFunction) func, PythonVarargsBuiltinNode.class);
+        CompilerAsserts.neverPartOfCompilation();
+        if (func instanceof PBuiltinFunction builtinFunc) {
+            NodeFactory<? extends PythonBuiltinBaseNode> builtinNodeFactory = builtinFunc.getBuiltinNodeFactory();
+            if (builtinNodeFactory == null) {
+                return null; // see for example MethodDescriptorRoot and subclasses
+            }
+            assert builtinNodeFactory.getNodeClass().getAnnotationsByType(Builtin.class).length > 0 : "PBuiltinFunction " + builtinFunc + " is expected to have a Builtin annotated node.";
+            if (builtinNodeFactory.getNodeClass().getAnnotationsByType(Builtin.class)[0].needsFrame() && frame == null) {
+                return null;
+            }
+            if (PythonVarargsBuiltinNode.class.isAssignableFrom(builtinNodeFactory.getNodeClass())) {
+                PythonVarargsBuiltinNode builtinNode = (PythonVarargsBuiltinNode) builtinFunc.getBuiltinNodeFactory().createNode();
+                if (!callerExceedsMaxSize(builtinNode)) {
+                    return builtinNode;
+                }
+            }
         }
         return null;
     }