Disallow annotating destructuring assignments

msimacek · msimacek · commit c4d3af1fa375 · 2020-06-22T11:24:51.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/parser/PythonSSTNodeFactory.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/parser/PythonSSTNodeFactory.java
@@ -187,6 +187,9 @@ public SSTNode createAssignment(SSTNode[] lhs, SSTNode rhs, int start, int stop)
     }
 
     public SSTNode createAnnAssignment(SSTNode lhs, SSTNode type, SSTNode rhs, int start, int end) {
+        if (lhs instanceof CollectionSSTNode) {
+            throw errors.raiseInvalidSyntax(source, createSourceSection(lhs.getStartOffset(), lhs.getEndOffset()), "only single target (not tuple) can be annotated");
+        }
         declareVar(lhs);
         if (!scopeEnvironment.getCurrentScope().hasAnnotations()) {
             scopeEnvironment.getCurrentScope().setHasAnnotations(true);

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,9 @@ public SSTNode createAssignment(SSTNode[] lhs, SSTNode rhs, int start, int stop)`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`public SSTNode createAnnAssignment(SSTNode lhs, SSTNode type, SSTNode rhs, int start, int end) {`
	`190`	`+ if (lhs instanceof CollectionSSTNode) {`
	`191`	`+ throw errors.raiseInvalidSyntax(source, createSourceSection(lhs.getStartOffset(), lhs.getEndOffset()), "only single target (not tuple) can be annotated");`
	`192`	`+ }`
`190`	`193`	`declareVar(lhs);`
`191`	`194`	`if (!scopeEnvironment.getCurrentScope().hasAnnotations()) {`
`192`	`195`	`scopeEnvironment.getCurrentScope().setHasAnnotations(true);`