remove reversible flag for CallBinaryMethodNode since now we're inlining these calls everywhere

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/CallBinaryMethodNode.java

@@ -59,11 +59,7 @@
 @ReportPolymorphism
 public abstract class CallBinaryMethodNode extends CallReversibleMethodNode {
     public static CallBinaryMethodNode create() {
-        return CallBinaryMethodNodeGen.create(false);
-    }
-
-    static CallBinaryMethodNode createReversed() {
-        return CallBinaryMethodNodeGen.create(true);
+        return CallBinaryMethodNodeGen.create();
     }
 
     public static CallBinaryMethodNode getUncached() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/CallReversibleMethodNode.java

@@ -43,21 +43,10 @@
 import com.oracle.graal.python.builtins.objects.function.PBuiltinFunction;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.RootCallTarget;
-import com.oracle.truffle.api.dsl.NodeField;
 
-@NodeField(name = "forReverseBinaryOperation", type = boolean.class)
 abstract class CallReversibleMethodNode extends CallSpecialMethodNode {
-    protected abstract boolean isForReverseBinaryOperation();
-
-    protected boolean isForReverseBinaryOperation(PBuiltinFunction func) {
-        boolean isReverseOperationSlot = func.isReverseOperationSlot();
-        CompilerAsserts.partialEvaluationConstant(isReverseOperationSlot);
-        return isForReverseBinaryOperation() && isReverseOperationSlot;
-    }
-
     protected boolean isForReverseBinaryOperation(RootCallTarget ct) {
-        boolean isReverseOperationSlot = PBuiltinFunction.isReverseOperationSlot(ct);
-        CompilerAsserts.partialEvaluationConstant(isReverseOperationSlot);
-        return isForReverseBinaryOperation() && isReverseOperationSlot;
+        CompilerAsserts.neverPartOfCompilation();
+        return PBuiltinFunction.isReverseOperationSlot(ct);
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/CallTernaryMethodNode.java

@@ -58,11 +58,7 @@
 @GenerateUncached
 public abstract class CallTernaryMethodNode extends CallReversibleMethodNode {
     public static CallTernaryMethodNode create() {
-        return CallTernaryMethodNodeGen.create(false);
-    }
-
-    static CallTernaryMethodNode createReversed() {
-        return CallTernaryMethodNodeGen.create(true);
+        return CallTernaryMethodNodeGen.create();
     }
 
     public static CallTernaryMethodNode getUncached() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupAndCallBinaryNode.java

@@ -147,7 +147,7 @@ private CallBinaryMethodNode ensureReverseDispatch() {
         // this also serves as a branch profile
         if (reverseDispatchNode == null) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
-            reverseDispatchNode = insert(CallBinaryMethodNode.createReversed());
+            reverseDispatchNode = insert(CallBinaryMethodNode.create());
         }
         return reverseDispatchNode;
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupAndCallTernaryNode.java

@@ -125,7 +125,7 @@ private CallTernaryMethodNode ensureReverseDispatch() {
         // this also serves as a branch profile
         if (reverseDispatchNode == null) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
-            reverseDispatchNode = insert(CallTernaryMethodNode.createReversed());
+            reverseDispatchNode = insert(CallTernaryMethodNode.create());
         }
         return reverseDispatchNode;
     }