Skip to content

Commit c52ef23

Browse files
committed
exclude at least some well known generated class name patterns
1 parent 463e858 commit c52ef23

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

mx.graalpython/mx_graalpython.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -382,11 +382,13 @@ def is_included(path):
382382
args += [_graalpytest_driver(), "-v"]
383383

384384
agent_args = " ".join(mx_gate.get_jacoco_agent_args() or [])
385-
# if we leave the excludes, the string is too long and it will be ignored by
386-
# the JVM. See
387-
# https://github.com/graalvm/graal-jvmci-8/blob/fc8a493bac33d35405c4361a134a812222c3d14b/src/share/vm/runtime/arguments.cpp#L3841
388-
agent_args = re.sub("excludes=[^,]+,", "", agent_args)
389385
if agent_args:
386+
# if we leave the excludes, the string is too long and it will be ignored by
387+
# the JVM, which ignores JAVA_TOOL_OPTIONS long than 1024 chars silently on JDK8
388+
agent_args = re.sub("excludes=[^,]+,", "", agent_args)
389+
# we know these can be excluded
390+
agent_args += ",excludes=*NodeGen*:*LibraryGen*:*BuiltinsFactory*"
391+
assert len(agent_args) < 1024
390392
# jacoco only dumps the data on exit, and when we run all our unittests
391393
# at once it generates so much data we run out of heap space
392394
with set_env(JAVA_TOOL_OPTIONS=agent_args):

0 commit comments

Comments
 (0)