Skip to content

Commit c7be640

Browse files
committed
include non-global symbols too while linking
1 parent 64d098b commit c7be640

File tree

1 file changed

+4
-4
lines changed
  • graalpython/com.oracle.graal.python.shell/src/com/oracle/graal/python/shell

1 file changed

+4
-4
lines changed

graalpython/com.oracle.graal.python.shell/src/com/oracle/graal/python/shell/GraalPythonLD.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,17 +248,17 @@ private Collection<? extends String> arMembers(String path) throws IOException,
248248
if (Files.probeContentType(Paths.get(f)).contains(LLVM_IR_BITCODE)) {
249249
HashSet<String> definedHere = new HashSet<>();
250250
ProcessBuilder nm = new ProcessBuilder();
251-
nm.command(LLVM_NM, "-g", "--defined-only", f);
251+
nm.command(LLVM_NM, "--defined-only", f);
252252
nm.redirectInput(Redirect.INHERIT);
253253
nm.redirectError(Redirect.INHERIT);
254254
nm.redirectOutput(Redirect.PIPE);
255255
Process nmProc = nm.start();
256256
try (BufferedReader buffer = new BufferedReader(new InputStreamReader(nmProc.getInputStream()))) {
257257
String line = null;
258258
while ((line = buffer.readLine()) != null) {
259-
String[] symboldef = line.split(" ");
259+
String[] symboldef = line.split(" [Tt]");
260260
if (symboldef.length >= 2) {
261-
definedHere.add(symboldef[symboldef.length - 1]);
261+
definedHere.add(symboldef[symboldef.length - 1].trim());
262262
}
263263
}
264264
}
@@ -267,7 +267,7 @@ private Collection<? extends String> arMembers(String path) throws IOException,
267267
ArrayList<String> extractCmd = new ArrayList<>();
268268
extractCmd.add("llvm-extract");
269269
for (String def : definedHere) {
270-
if (undefinedSymbols.contains(def)) {
270+
if (!definedSymbols.contains(def)) {
271271
definedSymbols.add(def);
272272
undefinedSymbols.remove(def);
273273
extractCmd.add("-func");

0 commit comments

Comments
 (0)