Revert dict checks

Author: qunaibit

graalpython/com.oracle.graal.python.test/src/tests/test_io.py

@@ -705,11 +705,7 @@ public Shape getBuiltinTypeInstanceShape(PythonBuiltinClassType type) {
         Shape shape = builtinTypeInstanceShapes[ordinal];
         if (shape == null) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
-            Shape.DerivedBuilder shapeBuilder = Shape.newBuilder(getEmptyShape()).addConstantProperty(HiddenAttributes.CLASS, type, 0);
-            if (!type.isBuiltinWithDict()) {
-                shapeBuilder.shapeFlags(PythonObject.HAS_SLOTS_BUT_NO_DICT_FLAG);
-            }
-            shape = shapeBuilder.build();
+            shape = Shape.newBuilder(getEmptyShape()).addConstantProperty(HiddenAttributes.CLASS, type, 0).build();
             builtinTypeInstanceShapes[ordinal] = shape;
         }
         return shape;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java

@@ -253,12 +253,11 @@ public enum PythonBuiltinClassType implements TruffleObject {
     // plain name without module
     private final String printName;
     private final boolean basetype;
-    private final boolean isBuiltinWithDict;
 
     // initialized in static constructor
     @CompilationFinal private PythonBuiltinClassType base;
 
-    PythonBuiltinClassType(String name, boolean isPublic, String module, boolean basetype, boolean isBuiltinWithDict) {
+    PythonBuiltinClassType(String name, boolean isPublic, String module, boolean basetype) {
         this.name = name;
         this.publicInModule = isPublic ? module : null;
         if (module != null && module != BuiltinNames.BUILTINS) {
@@ -267,11 +266,6 @@ public enum PythonBuiltinClassType implements TruffleObject {
             printName = name;
         }
         this.basetype = basetype;
-        this.isBuiltinWithDict = isBuiltinWithDict;
-    }
-
-    PythonBuiltinClassType(String name, boolean isPublic, String module, boolean baseType) {
-        this(name, isPublic, module, baseType, false);
     }
 
     PythonBuiltinClassType(String name, String publicInModule, boolean basetype) {
@@ -306,10 +300,6 @@ public PythonBuiltinClassType getBase() {
         return base;
     }
 
-    public boolean isBuiltinWithDict() {
-        return isBuiltinWithDict;
-    }
-
     public String getPublicInModule() {
         return publicInModule;
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

@@ -183,14 +183,6 @@ PException doPythonManagedClass(PythonManagedClass exceptionType, @SuppressWarni
         throw raiseExceptionObject(factory.createBaseException(exceptionType), language);
     }
 
-    @Specialization(guards = "isNoValue(cause)")
-    PException doPythonManagedClass(PythonManagedClass exceptionType, @SuppressWarnings("unused") PNone cause, String format, Object[] arguments,
-                    @Shared("factory") @Cached PythonObjectFactory factory,
-                    @Shared("language") @CachedLanguage PythonLanguage language) {
-        assert format != null;
-        throw raiseExceptionObject(factory.createBaseException(exceptionType, format, arguments), language);
-    }
-
     @Specialization(guards = {"isNoValue(cause)", "isNoValue(format)", "arguments.length > 0"})
     PException doBuiltinType(PythonBuiltinClassType type, @SuppressWarnings("unused") PNone cause, @SuppressWarnings("unused") PNone format, Object[] arguments,
                     @Shared("factory") @Cached PythonObjectFactory factory,