Bytecode DSL: forward the flag to venv lanuchers

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixSubprocessModuleBuiltins.java

@@ -44,9 +44,14 @@
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
 
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.Arrays;
 import java.util.List;
 
+import org.graalvm.nativeimage.ImageInfo;
+
 import com.oracle.graal.python.annotations.ArgumentClinic;
 import com.oracle.graal.python.annotations.ArgumentClinic.ClinicConversion;
 import com.oracle.graal.python.annotations.ClinicConverterFactory;
@@ -281,7 +286,7 @@ static int forkExec(VirtualFrame frame, Object[] args, Object executableList, bo
             Object[] executables = new Object[length];
             for (int i = 0; i < length; ++i) {
                 byte[] bytes = toBytesNode.execute(frame, getItem.execute(frame, inliningTarget, executableList, i));
-                if (Arrays.equals(bytes, sysExecutable)) {
+                if (Arrays.equals(bytes, sysExecutable) || isBytecodeDSLJvmVenvLauncher(context, bytes)) {
                     TruffleString[] additionalArgs = PythonOptions.getExecutableList(context);
                     if (length != 1 && additionalArgs.length != 1) {
                         throw raiseNode.raise(inliningTarget, ValueError, ErrorMessages.UNSUPPORTED_USE_OF_SYS_EXECUTABLE);
@@ -315,6 +320,30 @@ static int forkExec(VirtualFrame frame, Object[] args, Object executableList, bo
             }
         }
 
+        // On Bytecode DSL in JVM mode it is important to forward the Bytecode DSL flag
+        // Otherwise we do not forward flags for venv launchers and on Native Image the Bytecode DSL
+        // flag is baked into the image already
+        private static boolean isBytecodeDSLJvmVenvLauncher(PythonContext context, byte[] bytes) {
+            if (!PythonOptions.ENABLE_BYTECODE_DSL_INTERPRETER || ImageInfo.inImageRuntimeCode()) {
+                return false;
+            }
+            // best effort to find our if we are executing venv launcher
+            Path executablePath = Path.of(context.getOption(PythonOptions.Executable).toJavaStringUncached()).toAbsolutePath();
+            Path path = Path.of(new String(bytes));
+            while (Files.isSymbolicLink(path)) {
+                try {
+                    Path symlink = Files.readSymbolicLink(path);
+                    path = path.getParent().resolve(symlink).toAbsolutePath();
+                } catch (IOException ignore) {
+                    return false;
+                }
+                if (path.equals(executablePath)) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
         /**
          * Checks that the tuple contains only valid fds (positive integers fitting into an int) in
          * ascending order.