Remove PythonUtils.ASSERTIONS_ENABLED: it is not reliable on SVM

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

@@ -62,7 +62,6 @@
 import com.oracle.graal.python.builtins.objects.function.BuiltinMethodDescriptor;
 import com.oracle.graal.python.builtins.objects.type.SpecialMethodSlot;
 import com.oracle.graal.python.runtime.PythonContext;
-import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
@@ -732,7 +731,9 @@ public final Shape getInstanceShape(PythonLanguage lang) {
 
         Empty.base = Exception;
 
-        HashSet<String> set = PythonUtils.ASSERTIONS_ENABLED ? new HashSet<>() : null;
+        boolean assertionsEnabled = false;
+        assert (assertionsEnabled = true) == true;
+        HashSet<String> set = assertionsEnabled ? new HashSet<>() : null;
         for (PythonBuiltinClassType type : VALUES) {
             // check uniqueness
             assert set.add("" + type.moduleName + "." + type.name) : type.name();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/ObjectHashMap.java

@@ -768,7 +768,7 @@ private void compact() {
                 if (collision) {
                     markCollision(i);
                 }
-            } else if (PythonUtils.ASSERTIONS_ENABLED && index == DUMMY_INDEX) {
+            } else if (index == DUMMY_INDEX) {
                 dummyCount--;
             }
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java

@@ -1165,11 +1165,6 @@ public byte[] getHashSecret() {
     }
 
     public boolean isInitialized() {
-        if (PythonUtils.ASSERTIONS_ENABLED && isInitializedNonCompilationFinal != isInitialized) {
-            // We cannot use normal assertion, because those are removed in compilation
-            CompilerDirectives.transferToInterpreterAndInvalidate();
-            throw CompilerDirectives.shouldNotReachHere(String.format("%b != %b", isInitializedNonCompilationFinal, isInitialized));
-        }
         return isInitialized;
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/PythonUtils.java

@@ -99,17 +99,13 @@ public final class PythonUtils {
     public static final PCell[] NO_CLOSURE = new PCell[0];
     public static final ByteArraySupport arrayAccessor;
     public static final ConditionProfile[] DISABLED = new ConditionProfile[]{ConditionProfile.getUncached()};
-    public static final boolean ASSERTIONS_ENABLED;
 
     static {
         if (ByteOrder.nativeOrder() == ByteOrder.BIG_ENDIAN) {
             arrayAccessor = ByteArraySupport.bigEndian();
         } else {
             arrayAccessor = ByteArraySupport.littleEndian();
         }
-        boolean ae = false;
-        assert (ae = true) == true;
-        ASSERTIONS_ENABLED = ae;
     }
 
     private PythonUtils() {