Skip to content

Commit d4841b3

Browse files
committed
avoid materializing source sections on the fast path by not including rewritten functions in the stacktrace
1 parent 0472a49 commit d4841b3

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/FunctionRootNode.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,16 @@ public void setRewritten() {
164164
this.isRewritten = true;
165165
}
166166

167+
@Override
168+
public boolean isCaptureFramesForTrace() {
169+
return !isRewritten;
170+
}
171+
172+
@Override
173+
public boolean isInternal() {
174+
return isRewritten;
175+
}
176+
167177
@Override
168178
public void initializeFrame(VirtualFrame frame) {
169179
initClosureAndCellVars(frame);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/generator/GeneratorFunctionRootNode.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
package com.oracle.graal.python.nodes.generator;
4242

4343
import com.oracle.graal.python.PythonLanguage;
44-
import com.oracle.graal.python.builtins.objects.function.Signature;
4544
import com.oracle.graal.python.builtins.objects.function.PArguments;
45+
import com.oracle.graal.python.builtins.objects.function.Signature;
4646
import com.oracle.graal.python.nodes.PClosureFunctionRootNode;
4747
import com.oracle.graal.python.parser.ExecutionCellSlots;
4848
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
@@ -88,6 +88,16 @@ public String getName() {
8888
return name;
8989
}
9090

91+
@Override
92+
public boolean isCaptureFramesForTrace() {
93+
return false;
94+
}
95+
96+
@Override
97+
public boolean isInternal() {
98+
return true;
99+
}
100+
91101
@Override
92102
public void initializeFrame(VirtualFrame frame) {
93103
// nothing to do

0 commit comments

Comments
 (0)