Skip to content

Commit d694170

Browse files
committed
removed leaking cache in ConverterFactory
1 parent c191a11 commit d694170

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

graalpython/com.oracle.graal.python.processor/src/com/oracle/graal/python/processor/ConverterFactory.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@
4242

4343
import java.util.ArrayList;
4444
import java.util.Arrays;
45-
import java.util.HashMap;
4645
import java.util.List;
47-
import java.util.Map;
4846

4947
import javax.lang.model.element.Element;
5048
import javax.lang.model.element.ElementKind;
@@ -88,8 +86,6 @@ public enum Param {
8886
Extra,
8987
}
9088

91-
private static final Map<TypeElement, ConverterFactory[]> cache = new HashMap<>();
92-
9389
private static ConverterFactory[] BuiltinBoolean;
9490
private static ConverterFactory[] BuiltinIntToBoolean;
9591
private static ConverterFactory[] BuiltinString;
@@ -167,10 +163,6 @@ public static ConverterFactory[] getBuiltin(ArgumentClinic annotation) {
167163
}
168164

169165
public static ConverterFactory[] getForClass(TypeElement conversionClass) throws ProcessingError {
170-
ConverterFactory[] cached = cache.get(conversionClass);
171-
if (cached != null) {
172-
return cached;
173-
}
174166
ArrayList<ConverterFactory> factories = new ArrayList<>();
175167
for (Element e : conversionClass.getEnclosedElements()) {
176168
ClinicConverterFactory annot = e.getAnnotation(ClinicConverterFactory.class);
@@ -212,7 +204,6 @@ public static ConverterFactory[] getForClass(TypeElement conversionClass) throws
212204
throw new ProcessingError(conversionClass, "No ClinicConverterFactory annotation found.");
213205
}
214206
ConverterFactory[] result = factories.toArray(new ConverterFactory[0]);
215-
cache.put(conversionClass, result);
216207
return result;
217208
}
218209

0 commit comments

Comments
 (0)