isDictUnsetOrSameAsStorage: getDict value profile not needed since we cache the dict class in the getDictStorageNode

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/ObjectAttributeNode.java

@@ -75,8 +75,8 @@ protected Object attrKey(Object key) {
         }
     }
 
-    protected boolean isDictUnsetOrSameAsStorage(PythonObject object, ValueProfile dictClassProfile) {
-        PHashingCollection dict = dictClassProfile.profile(object.getDict());
+    protected boolean isDictUnsetOrSameAsStorage(PythonObject object) {
+        PHashingCollection dict = object.getDict();
         if (dict == null) {
             return true;
         } else {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/ReadAttributeFromObjectNode.java

@@ -60,8 +60,6 @@
 
 @ImportStatic({PGuards.class, PythonOptions.class})
 public abstract class ReadAttributeFromObjectNode extends ObjectAttributeNode {
-    protected final ValueProfile dictClassProfile = ValueProfile.createClassProfile();
-
     public static ReadAttributeFromObjectNode create() {
         return ReadAttributeFromObjectNodeGen.create();
     }
@@ -82,7 +80,7 @@ protected Object readFromDynamicStorageCached(PythonObject object, Object key,
     }
 
     @Specialization(guards = {
-                    "isDictUnsetOrSameAsStorage(object, dictClassProfile)"
+                    "isDictUnsetOrSameAsStorage(object)"
     }, replaces = "readFromDynamicStorageCached")
     protected Object readFromDynamicStorage(PythonObject object, Object key,
                     @Cached("create()") ReadAttributeFromDynamicObjectNode readAttributeFromDynamicObjectNode) {
@@ -107,7 +105,7 @@ protected Object readFromDictCached(PythonObject object, Object key,
     }
 
     @Specialization(guards = {
-                    "!isDictUnsetOrSameAsStorage(object, dictClassProfile)"
+                    "!isDictUnsetOrSameAsStorage(object)"
     }, replaces = "readFromDictCached")
     protected Object readFromDict(PythonObject object, Object key,
                     @Cached("create()") HashingStorageNodes.GetItemNode getItemNode) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/WriteAttributeToObjectNode.java

@@ -66,8 +66,6 @@ public abstract class WriteAttributeToObjectNode extends ObjectAttributeNode {
     private final ConditionProfile isClassProfile = ConditionProfile.createBinaryProfile();
     private final IsBuiltinClassProfile exactBuiltinInstanceProfile = IsBuiltinClassProfile.create();
 
-    protected final ValueProfile dictClassProfile = ValueProfile.createClassProfile();
-
     public abstract boolean execute(Object primary, Object key, Object value);
 
     public abstract boolean execute(Object primary, String key, Object value);
@@ -108,7 +106,7 @@ protected boolean writeToDynamicStorageCached(PythonObject object, Object key, O
 
     @Specialization(guards = {
                     "isAttrWritable(object) || isHiddenKey(key)",
-                    "isDictUnsetOrSameAsStorage(object, dictClassProfile)"
+                    "isDictUnsetOrSameAsStorage(object)"
     }, replaces = "writeToDynamicStorageCached")
     protected boolean writeToDynamicStorage(PythonObject object, Object key, Object value,
                     @Cached("create()") WriteAttributeToDynamicObjectNode writeAttributeToDynamicObjectNode) {
@@ -133,7 +131,7 @@ protected boolean writeToDictCached(PythonObject object, Object key, Object valu
     }
 
     @Specialization(guards = {
-                    "!isDictUnsetOrSameAsStorage(object, dictClassProfile)"
+                    "!isDictUnsetOrSameAsStorage(object)"
     }, replaces = "writeToDictCached")
     protected boolean writeToDict(PythonObject object, Object key, Object value,
                     @Cached("create()") HashingStorageNodes.SetItemNode setItemNode) {