Skip to content

Commit da33164

Browse files
committed
[GR-21867] Remove LazyPythonClass
PullRequest: graalpython/1050
2 parents 712ae45 + ea0858a commit da33164

30 files changed

+365
-351
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@
172172
import com.oracle.graal.python.builtins.objects.thread.ThreadBuiltins;
173173
import com.oracle.graal.python.builtins.objects.traceback.TracebackBuiltins;
174174
import com.oracle.graal.python.builtins.objects.tuple.TupleBuiltins;
175-
import com.oracle.graal.python.builtins.objects.type.LazyPythonClass;
176175
import com.oracle.graal.python.builtins.objects.type.PythonBuiltinClass;
177176
import com.oracle.graal.python.builtins.objects.type.TypeBuiltins;
178177
import com.oracle.graal.python.builtins.objects.type.TypeNodes.GetNameNode;
@@ -747,7 +746,7 @@ public SourceSection getSourceSection() {
747746
@TruffleBoundary
748747
public RuntimeException raiseInvalidSyntax(PythonParser.ErrorType type, Node location, String message, Object... arguments) {
749748
PBaseException instance;
750-
LazyPythonClass cls;
749+
Object cls;
751750
switch (type) {
752751
case Indentation:
753752
cls = IndentationError;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ public boolean isAcceptableBase() {
240240
return basetype;
241241
}
242242

243-
@Override
244243
public String getName() {
245244
return name;
246245
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ArrayModuleBuiltins.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import com.oracle.graal.python.builtins.objects.common.SequenceNodes;
4141
import com.oracle.graal.python.builtins.objects.common.SequenceStorageNodes;
4242
import com.oracle.graal.python.builtins.objects.range.PRange;
43-
import com.oracle.graal.python.builtins.objects.type.LazyPythonClass;
4443
import com.oracle.graal.python.nodes.ErrorMessages;
4544
import com.oracle.graal.python.nodes.control.GetIteratorExpressionNode.GetIteratorNode;
4645
import com.oracle.graal.python.nodes.control.GetNextNode;
@@ -71,15 +70,15 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
7170
abstract static class PythonArrayNode extends PythonBuiltinNode {
7271

7372
@Specialization(guards = "isNoValue(initializer)")
74-
PArray array(LazyPythonClass cls, String typeCode, @SuppressWarnings("unused") PNone initializer) {
73+
PArray array(Object cls, String typeCode, @SuppressWarnings("unused") PNone initializer) {
7574
/**
7675
* TODO @param typeCode should be a char, not a string
7776
*/
7877
return makeEmptyArray(cls, typeCode.charAt(0));
7978
}
8079

8180
@Specialization
82-
PArray arrayWithRangeInitializer(LazyPythonClass cls, String typeCode, PRange range) {
81+
PArray arrayWithRangeInitializer(Object cls, String typeCode, PRange range) {
8382
if (!typeCode.equals("i")) {
8483
typeError(typeCode, range);
8584
}
@@ -99,7 +98,7 @@ PArray arrayWithRangeInitializer(LazyPythonClass cls, String typeCode, PRange ra
9998
}
10099

101100
@Specialization
102-
PArray arrayWithSequenceInitializer(LazyPythonClass cls, String typeCode, String str) {
101+
PArray arrayWithSequenceInitializer(Object cls, String typeCode, String str) {
103102
if (!typeCode.equals("c")) {
104103
typeError(typeCode, str);
105104
}
@@ -128,7 +127,7 @@ protected boolean isDoubleArray(String typeCode) {
128127
}
129128

130129
@Specialization(guards = "isByteArray(typeCode)")
131-
PArray arrayByteInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
130+
PArray arrayByteInitializer(VirtualFrame frame, Object cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
132131
@Cached("createCast()") CastToByteNode castToByteNode,
133132
@Cached("create()") GetIteratorNode getIterator,
134133
@Cached("create()") GetNextNode next,
@@ -153,15 +152,15 @@ PArray arrayByteInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWa
153152
}
154153

155154
@Specialization(guards = "isCharArray(typeCode)")
156-
PArray arrayCharInitializer(LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
155+
PArray arrayCharInitializer(Object cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
157156
@Cached SequenceNodes.GetSequenceStorageNode getSequenceStorageNode,
158157
@Cached SequenceStorageNodes.ToByteArrayNode toByteArrayNode) {
159158
byte[] byteArray = toByteArrayNode.execute(getSequenceStorageNode.execute(initializer));
160159
return factory().createArray(cls, byteArray);
161160
}
162161

163162
@Specialization(guards = "isIntArray(typeCode)")
164-
PArray arrayIntInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
163+
PArray arrayIntInitializer(VirtualFrame frame, Object cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
165164
@Cached("create()") GetIteratorNode getIterator,
166165
@Cached("create()") GetNextNode next,
167166
@Cached("create()") IsBuiltinClassProfile errorProfile,
@@ -190,7 +189,7 @@ PArray arrayIntInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWar
190189
}
191190

192191
@Specialization(guards = "isLongArray(typeCode)")
193-
PArray arrayLongInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
192+
PArray arrayLongInitializer(VirtualFrame frame, Object cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
194193
@Cached("create()") GetIteratorNode getIterator,
195194
@Cached("create()") GetNextNode next,
196195
@Cached("create()") IsBuiltinClassProfile errorProfile,
@@ -219,7 +218,7 @@ PArray arrayLongInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWa
219218
}
220219

221220
@Specialization(guards = "isDoubleArray(typeCode)")
222-
PArray arrayDoubleInitializer(VirtualFrame frame, LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
221+
PArray arrayDoubleInitializer(VirtualFrame frame, Object cls, @SuppressWarnings("unused") String typeCode, PSequence initializer,
223222
@Cached("create()") GetIteratorNode getIterator,
224223
@Cached("create()") GetNextNode next,
225224
@Cached("create()") IsBuiltinClassProfile errorProfile,
@@ -251,7 +250,7 @@ PArray arrayDoubleInitializer(VirtualFrame frame, LazyPythonClass cls, @Suppress
251250

252251
@Specialization
253252
@TruffleBoundary
254-
PArray arrayWithObjectInitializer(@SuppressWarnings("unused") LazyPythonClass cls, @SuppressWarnings("unused") String typeCode, Object initializer) {
253+
PArray arrayWithObjectInitializer(@SuppressWarnings("unused") Object cls, @SuppressWarnings("unused") String typeCode, Object initializer) {
255254
if (!(isIntArray(typeCode) || isByteArray(typeCode) || isDoubleArray(typeCode) || isCharArray(typeCode))) {
256255
// TODO implement support for typecodes: b, B, u, h, H, i, I, l, L, q, Q, f or d
257256
throw raise(ValueError, ErrorMessages.BAD_TYPECODE);
@@ -260,7 +259,7 @@ PArray arrayWithObjectInitializer(@SuppressWarnings("unused") LazyPythonClass cl
260259
}
261260

262261
@Specialization(guards = "!isString(typeCode)")
263-
PArray noArray(@SuppressWarnings("unused") LazyPythonClass cls, Object typeCode, @SuppressWarnings("unused") Object initializer) {
262+
PArray noArray(@SuppressWarnings("unused") Object cls, Object typeCode, @SuppressWarnings("unused") Object initializer) {
264263
throw raise(TypeError, ErrorMessages.ARG_MUST_BE_UNICODE, "array()", 1, typeCode);
265264
}
266265

0 commit comments

Comments
 (0)