fixed error type when setting an readonly buitin attr

Author: tomasstupka

graalpython/com.oracle.graal.python.test/src/tests/test_type.py

@@ -329,4 +329,66 @@ class C():
 
     class C(tuple):
         __itemsize__ = 42
-    assert C.__itemsize__ == 8
+    assert C.__itemsize__ == 8
+    
+def test_descr_name_qualname():    
+    assert float.real.__qualname__ == 'float.real'
+    assert float.real.__name__ == 'real'
+    class C: __slots__ = ['a']
+    assert C.a.__name__ == 'a'
+    assert C.a.__qualname__ == 'test_descr_name_qualname.<locals>.C.a'
+    raised = False
+    try:
+        C.a.__qualname__ = 'b'
+    except AttributeError:
+        raised = True
+    assert raised    
+    raised = False
+    try:
+        C.a.__name__ = 'b'
+    except AttributeError:
+        raised = True
+    assert raised    
+    
+def test_cant_set_builtin_attributes():
+    raised = False
+    try:
+        float.__name__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised
+    
+    raised = False
+    try:
+        float.__qualname__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised
+    
+    raised = False
+    try:
+        float.__dictoffset__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised
+    
+    raised = False
+    try:
+        float.__module__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised
+    
+    raised = False
+    try:
+        float.__itemsize__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised
+    
+    raised = False
+    try:
+        float.__basicsize__ = 'b'
+    except TypeError:
+        raised = True
+    assert raised    

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/TypeBuiltins.java

@@ -852,12 +852,12 @@ static String getNameBuiltin(PythonManagedClass cls, @SuppressWarnings("unused")
 
         @Specialization(guards = "!isNoValue(value)")
         Object setName(@SuppressWarnings("unused") PythonBuiltinClassType cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = "!isNoValue(value)")
         Object setName(@SuppressWarnings("unused") PythonBuiltinClass cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = {"!isNoValue(value)", "!isPythonBuiltinClass(cls)"})
@@ -943,6 +943,16 @@ Object setNative(@SuppressWarnings("unused") PythonNativeClass cls, @SuppressWar
             throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "native type");
         }
 
+        @Specialization(guards = "!isNoValue(value)")
+        Object setModuleType(@SuppressWarnings("unused") PythonBuiltinClassType cls, @SuppressWarnings("unused") Object value) {
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+        }
+
+        @Specialization(guards = "!isNoValue(value)")
+        Object setModuleBuiltin(@SuppressWarnings("unused") PythonBuiltinClass cls, @SuppressWarnings("unused") Object value) {
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+        }
+
         @TruffleBoundary
         private static Object getModuleName(String fqname) {
             int firstDotIdx = fqname.indexOf('.');
@@ -967,7 +977,7 @@ static String getName(PythonManagedClass cls, @SuppressWarnings("unused") PNone
 
         @Specialization(guards = "!isNoValue(value)")
         Object setName(@SuppressWarnings("unused") PythonBuiltinClass cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = {"!isNoValue(value)", "!isPythonBuiltinClass(cls)"})
@@ -1026,12 +1036,12 @@ static Object getDictoffsetManaged(PythonManagedClass cls, @SuppressWarnings("un
 
         @Specialization(guards = "!isNoValue(value)")
         Object setDictoffsetType(@SuppressWarnings("unused") PythonBuiltinClassType cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = "!isNoValue(value)")
         Object setDictoffsetBuiltin(@SuppressWarnings("unused") PythonBuiltinClass cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = {"!isNoValue(value)", "!isPythonBuiltinClass(cls)"})
@@ -1118,12 +1128,12 @@ static Object getBasicsizeManaged(PythonManagedClass cls, @SuppressWarnings("unu
 
         @Specialization(guards = "!isNoValue(value)")
         Object setBasicsizeType(@SuppressWarnings("unused") PythonBuiltinClassType cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = "!isNoValue(value)")
         Object setBasicsizeBuiltin(@SuppressWarnings("unused") PythonBuiltinClass cls, @SuppressWarnings("unused") Object value) {
-            throw raise(PythonErrorType.RuntimeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
+            throw raise(PythonErrorType.TypeError, ErrorMessages.CANT_SET_ATTRIBUTES_OF_TYPE, "built-in/extension 'type'");
         }
 
         @Specialization(guards = {"!isNoValue(value)", "!isPythonBuiltinClass(cls)"})