Add PyFloat_FromString

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/cpyext/test_float.py

@@ -130,6 +130,23 @@ def compile_module(self, name):
         cmpfunc=_float_compare
     )
 
+    test_PyFloat_FromString = CPyExtFunction(
+        lambda args: float(args[0]),
+        lambda: (
+            ("1",),
+            ("0.0",),
+            ("-1.0",),
+            ("-11.123456789123456789",),
+            ("nan",),
+            ("-inf",),
+            ("not-a-float",),
+        ),
+        resultspec="O",
+        argspec='O',
+        arguments=["PyObject* string"],
+        cmpfunc=_float_compare
+    )
+
     test_PyFloat_Check = CPyExtFunction(
         lambda args: isinstance(args[0], float),
         lambda: (

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextFloatBuiltins.java

@@ -44,6 +44,7 @@
 import static com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiCallPath.Direct;
 import static com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiCallPath.Ignored;
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObject;
+import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObjectAsTruffleString;
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObjectTransfer;
 import static com.oracle.graal.python.nodes.ErrorMessages.BAD_ARG_TO_INTERNAL_FUNC_WAS_S_P;
 
@@ -52,8 +53,10 @@
 import com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiUnaryBuiltinNode;
 import com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor;
 import com.oracle.graal.python.lib.PyFloatAsDoubleNode;
+import com.oracle.graal.python.lib.PyFloatFromString;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.strings.TruffleString;
 
 public final class PythonCextFloatBuiltins {
 
@@ -92,4 +95,14 @@ static double doGenericErr(Object object,
             return asDoubleNode.execute(null, object);
         }
     }
+
+    @CApiBuiltin(ret = PyObjectTransfer, args = {PyObjectAsTruffleString}, call = Direct)
+    abstract static class PyFloat_FromString extends CApiUnaryBuiltinNode {
+
+        @Specialization
+        static Object fromString(TruffleString string,
+                        @Cached PyFloatFromString pyFloatFromString) {
+            return pyFloatFromString.execute(null, string);
+        }
+    }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiFunction.java

@@ -1112,7 +1112,6 @@ public final class CApiFunction {
     @CApiBuiltin(name = "PyFile_OpenCode", ret = PyObject, args = {ConstCharPtrAsTruffleString}, call = NotImplemented)
     @CApiBuiltin(name = "PyFile_OpenCodeObject", ret = PyObject, args = {PyObject}, call = NotImplemented)
     @CApiBuiltin(name = "PyFile_SetOpenCodeHook", ret = Int, args = {PY_OPENCODEHOOKFUNCTION, Pointer}, call = NotImplemented)
-    @CApiBuiltin(name = "PyFloat_FromString", ret = PyObject, args = {PyObject}, call = NotImplemented)
     @CApiBuiltin(name = "PyFloat_GetInfo", ret = PyObject, args = {}, call = NotImplemented)
     @CApiBuiltin(name = "PyFloat_GetMax", ret = Double, args = {}, call = NotImplemented)
     @CApiBuiltin(name = "PyFloat_GetMin", ret = Double, args = {}, call = NotImplemented)