[GR-10285] divmod doesn't throw TypeError, when it called with complex numbers.

PullRequest: graalpython/316

Author: ppisl

graalpython/com.oracle.graal.python.test/src/tests/test_builtin.py

@@ -31,3 +31,9 @@ def test_GR11897(self):
         code = 'a' + ' = ' + '8.01234567890123'
         exec(code, globs)
         self.assertEqual(globs['a'], 8.01234567890123)
+
+    def test_divmod_complex(self):
+        c1, c2 = complex(3, 2), complex(4,1)
+        self.assertRaises(TypeError, divmod, c1, c2)
+        self.assertRaises(TypeError, divmod, 10, c2)
+        self.assertRaises(TypeError, divmod, c1, 10)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -95,6 +95,7 @@
 import com.oracle.graal.python.builtins.objects.common.PHashingCollection;
 import com.oracle.graal.python.builtins.objects.common.SequenceNodes;
 import com.oracle.graal.python.builtins.objects.common.SequenceStorageNodes;
+import com.oracle.graal.python.builtins.objects.complex.PComplex;
 import com.oracle.graal.python.builtins.objects.dict.PDict;
 import com.oracle.graal.python.builtins.objects.frame.FrameBuiltins.GetLocalsNode;
 import com.oracle.graal.python.builtins.objects.function.Arity;
@@ -504,6 +505,18 @@ public PTuple doDouble(double a, double b) {
             return factory().createTuple(new Object[]{q, a % b});
         }
 
+        @Specialization
+        @SuppressWarnings("unused")
+        public PTuple doComplex(PComplex c, Object o) {
+            throw raise(PythonErrorType.TypeError, "can't take floor or mod of complex number.");
+        }
+
+        @Specialization
+        @SuppressWarnings("unused")
+        public PTuple doComplex(Object o, PComplex c) {
+            throw raise(PythonErrorType.TypeError, "can't take floor or mod of complex number.");
+        }
+
         @Specialization
         public PTuple doObject(Object a, Object b,
                         @Cached("create(__FLOORDIV__)") LookupAndCallBinaryNode floordivNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/complex/ComplexBuiltins.java

@@ -61,6 +61,7 @@
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__STR__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__SUB__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__TRUEDIV__;
+import static com.oracle.graal.python.nodes.SpecialMethodNames.__DIVMOD__;
 
 import java.util.List;
 
@@ -76,6 +77,7 @@
 import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.truffle.PythonArithmeticTypes;
+import com.oracle.graal.python.runtime.exception.PythonErrorType;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
@@ -306,6 +308,17 @@ PNotImplemented doComplex(Object left, Object right) {
         }
     }
 
+    @GenerateNodeFactory
+    @Builtin(name = __DIVMOD__, fixedNumOfPositionalArgs = 2)
+    static abstract class DivModNode extends PythonBinaryBuiltinNode {
+
+        @Specialization
+        @SuppressWarnings("unused")
+        PComplex doComplexDouble(Object right, Object left) {
+            throw raise(PythonErrorType.TypeError, "can't take floor or mod of complex number.");
+        }
+    }
+
     @GenerateNodeFactory
     @Builtin(name = __MUL__, fixedNumOfPositionalArgs = 2)
     @TypeSystemReference(PythonArithmeticTypes.class)