Skip to content

Commit e1adf51

Browse files
committed
Review @InliningCutoffs in Bytecode DSL interpreter
1 parent e85e9ec commit e1adf51

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode_dsl/PBytecodeDSLRootNode.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,6 @@ public static Object doIt(VirtualFrame frame,
15381538
@ConstantOperand(type = TruffleString.class)
15391539
public static final class GetAttribute {
15401540
@Specialization
1541-
@InliningCutoff
15421541
public static Object doIt(VirtualFrame frame,
15431542
TruffleString name,
15441543
Object obj,
@@ -1551,7 +1550,6 @@ public static Object doIt(VirtualFrame frame,
15511550
@ConstantOperand(type = TruffleString.class)
15521551
public static final class SetAttribute {
15531552
@Specialization
1554-
@InliningCutoff
15551553
public static void doIt(VirtualFrame frame,
15561554
TruffleString key,
15571555
Object value,
@@ -2477,7 +2475,6 @@ public static AbstractTruffleException doPException(VirtualFrame frame) {
24772475
@Operation
24782476
public static final class SetCurrentException {
24792477
@Specialization
2480-
@InliningCutoff
24812478
public static void doPException(VirtualFrame frame, Object ex) {
24822479
PArguments.setException(frame, (AbstractTruffleException) ex);
24832480
}
@@ -2488,7 +2485,6 @@ public static void doPException(VirtualFrame frame, Object ex) {
24882485
@ConstantOperand(type = boolean.class)
24892486
public static final class SetCurrentGeneratorException {
24902487
@Specialization
2491-
@InliningCutoff
24922488
public static void doPException(VirtualFrame frame, LocalAccessor currentGeneratorException, boolean clearGeneratorEx, Object ex,
24932489
@Bind BytecodeNode bytecode) {
24942490
if (clearGeneratorEx) {
@@ -2503,21 +2499,20 @@ public static void doPException(VirtualFrame frame, LocalAccessor currentGenerat
25032499
@Operation(storeBytecodeIndex = false)
25042500
public static final class MarkExceptionAsCaught {
25052501
@Specialization
2506-
@InliningCutoff
25072502
public static void doPException(VirtualFrame frame, PException ex,
25082503
@Bind PBytecodeDSLRootNode rootNode) {
25092504
ex.markAsCaught(frame, rootNode);
25102505
}
25112506

25122507
@Fallback
2513-
@InliningCutoff
25142508
public static void doNothing(@SuppressWarnings("unused") Object ex) {
25152509
}
25162510
}
25172511

25182512
@Operation(storeBytecodeIndex = true)
25192513
public static final class AssertFailed {
25202514
@Specialization
2515+
@InliningCutoff
25212516
public static void doAssertFailed(VirtualFrame frame, Object assertionMessage,
25222517
@Bind PBytecodeDSLRootNode rooNode) {
25232518
if (assertionMessage == PNone.NO_VALUE) {
@@ -2917,7 +2912,6 @@ private static void copyItemsToArray(Node inliningTarget, SequenceStorage source
29172912
@Operation(storeBytecodeIndex = true)
29182913
public static final class CallNilaryMethod {
29192914
@Specialization
2920-
@InliningCutoff
29212915
public static Object doCall(VirtualFrame frame, Object callable,
29222916
@Cached CallNode node) {
29232917
return node.execute(frame, callable, PythonUtils.EMPTY_OBJECT_ARRAY, PKeyword.EMPTY_KEYWORDS);
@@ -2927,7 +2921,6 @@ public static Object doCall(VirtualFrame frame, Object callable,
29272921
@Operation(storeBytecodeIndex = true)
29282922
public static final class CallUnaryMethod {
29292923
@Specialization
2930-
@InliningCutoff
29312924
public static Object doCall(VirtualFrame frame, Object callable, Object arg0,
29322925
@Cached CallUnaryMethodNode node) {
29332926
return node.executeObject(frame, callable, arg0);
@@ -2937,7 +2930,6 @@ public static Object doCall(VirtualFrame frame, Object callable, Object arg0,
29372930
@Operation(storeBytecodeIndex = true)
29382931
public static final class CallBinaryMethod {
29392932
@Specialization
2940-
@InliningCutoff
29412933
public static Object doObject(VirtualFrame frame, Object callable, Object arg0, Object arg1,
29422934
@Cached CallBinaryMethodNode node) {
29432935
return node.executeObject(frame, callable, arg0, arg1);
@@ -2947,7 +2939,6 @@ public static Object doObject(VirtualFrame frame, Object callable, Object arg0,
29472939
@Operation(storeBytecodeIndex = true)
29482940
public static final class CallTernaryMethod {
29492941
@Specialization
2950-
@InliningCutoff
29512942
public static Object doCall(VirtualFrame frame, Object callable, Object arg0, Object arg1, Object arg2,
29522943
@Cached CallTernaryMethodNode node) {
29532944
return node.execute(frame, callable, arg0, arg1, arg2);
@@ -2957,7 +2948,6 @@ public static Object doCall(VirtualFrame frame, Object callable, Object arg0, Ob
29572948
@Operation(storeBytecodeIndex = true)
29582949
public static final class CallQuaternaryMethod {
29592950
@Specialization
2960-
@InliningCutoff
29612951
public static Object doCall(VirtualFrame frame, Object callable, Object arg0, Object arg1, Object arg2, Object arg3,
29622952
@Cached CallQuaternaryMethodNode node) {
29632953
return node.execute(frame, callable, arg0, arg1, arg2, arg3);
@@ -2967,7 +2957,6 @@ public static Object doCall(VirtualFrame frame, Object callable, Object arg0, Ob
29672957
@Operation(storeBytecodeIndex = true)
29682958
public static final class CallVarargsMethod {
29692959
@Specialization
2970-
@InliningCutoff
29712960
public static Object doCall(VirtualFrame frame, Object callable, Object[] args, PKeyword[] keywords,
29722961
@Cached CallNode node) {
29732962
return node.execute(frame, callable, args, keywords);
@@ -2979,7 +2968,6 @@ public static Object doCall(VirtualFrame frame, Object callable, Object[] args,
29792968
@ConstantOperand(type = LocalAccessor.class)
29802969
public static final class ContextManagerEnter {
29812970
@Specialization
2982-
@InliningCutoff
29832971
public static void doEnter(VirtualFrame frame,
29842972
LocalAccessor exitSetter,
29852973
LocalAccessor resultSetter,
@@ -3084,6 +3072,7 @@ public static void doEnter(VirtualFrame frame,
30843072
@Operation(storeBytecodeIndex = true)
30853073
public static final class AsyncContextManagerCallExit {
30863074
@Specialization
3075+
@InliningCutoff
30873076
public static Object doRegular(VirtualFrame frame,
30883077
PNone none, Object exit, Object contextManager,
30893078
@Shared @Cached CallQuaternaryMethodNode callExit) {

0 commit comments

Comments
 (0)