Move BigInteger.abs() call outside TruffleBoundary

otethal · otethal · commit e427508967a1 · 2020-07-09T10:15:12.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java
@@ -279,11 +279,16 @@ protected String bigToString(BigInteger x) {
             return x.toString(2);
         }
 
+        @TruffleBoundary
+        protected BigInteger bigAbs(BigInteger x) {
+            return x.abs();
+        }
+
         @Specialization
         String doL(long x,
                         @Cached ConditionProfile isMinLong) {
             if (isMinLong.profile(x == Long.MIN_VALUE)) {
-                return buildString(true, bigToString(PInt.longToBigInteger(x).abs()));
+                return buildString(true, bigToString(bigAbs(PInt.longToBigInteger(x))));
             }
             return buildString(x < 0, longToString(Math.abs(x)));
         }

Original file line number	Diff line number	Diff line change
`@@ -279,11 +279,16 @@ protected String bigToString(BigInteger x) {`
`279`	`279`	`return x.toString(2);`
`280`	`280`	`}`
`281`	`281`
	`282`	`+ @TruffleBoundary`
	`283`	`+ protected BigInteger bigAbs(BigInteger x) {`
	`284`	`+ return x.abs();`
	`285`	`+ }`
	`286`	`+`
`282`	`287`	`@Specialization`
`283`	`288`	`String doL(long x,`
`284`	`289`	`@Cached ConditionProfile isMinLong) {`
`285`	`290`	`if (isMinLong.profile(x == Long.MIN_VALUE)) {`
`286`		`- return buildString(true, bigToString(PInt.longToBigInteger(x).abs()));`
	`291`	`+ return buildString(true, bigToString(bigAbs(PInt.longToBigInteger(x))));`
`287`	`292`	`}`
`288`	`293`	`return buildString(x < 0, longToString(Math.abs(x)));`
`289`	`294`	`}`