[GR-52203] Fix UnsupportedSpecializationException in richcompare nodes.

PullRequest: graalpython/3208

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntBuiltins.java

@@ -123,6 +123,7 @@
 import com.oracle.graal.python.builtins.objects.ints.IntBuiltinsClinicProviders.FormatNodeClinicProviderGen;
 import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.builtins.objects.type.PythonBuiltinClass;
+import com.oracle.graal.python.lib.PyLongCheckNode;
 import com.oracle.graal.python.lib.PyNumberFloatNode;
 import com.oracle.graal.python.lib.PyObjectHashNode;
 import com.oracle.graal.python.nodes.ErrorMessages;
@@ -2648,8 +2649,13 @@ abstract static class RichCompareNode extends PythonTernaryBuiltinNode {
         @Specialization(guards = {"opCode == cachedOp.opCode"}, limit = "6")
         static Object doCached(Object left, Object right, @SuppressWarnings("unused") int opCode,
                         @Bind("this") Node inliningTarget,
+                        @Cached PyLongCheckNode checkLeft,
+                        @Cached PyLongCheckNode checkRight,
                         @SuppressWarnings("unused") @Cached("fromOpCode(opCode)") ComparisonOp cachedOp,
                         @Cached RichCompareHelperNode cmpNode) {
+            if (!checkLeft.execute(inliningTarget, left) || !checkRight.execute(inliningTarget, right)) {
+                return PNotImplemented.NOT_IMPLEMENTED;
+            }
             return cmpNode.execute(inliningTarget, left, right, cachedOp);
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

@@ -135,6 +135,7 @@
 import com.oracle.graal.python.lib.PyNumberAsSizeNode;
 import com.oracle.graal.python.lib.PyObjectGetItem;
 import com.oracle.graal.python.lib.PyObjectHashNode;
+import com.oracle.graal.python.lib.PyUnicodeCheckNode;
 import com.oracle.graal.python.nodes.ErrorMessages;
 import com.oracle.graal.python.nodes.PGuards;
 import com.oracle.graal.python.nodes.PRaiseNode;
@@ -515,15 +516,25 @@ abstract static class RichCompareNode extends PythonTernaryBuiltinNode {
         @Specialization(guards = "isEqualityOpCode(opCode)")
         static Object doEqNeOp(Object left, Object right, int opCode,
                         @Bind("this") Node inliningTarget,
+                        @Exclusive @Cached PyUnicodeCheckNode checkLeft,
+                        @Exclusive @Cached PyUnicodeCheckNode checkRight,
                         @Cached StringEqOpHelperNode stringEqOpHelperNode) {
+            if (!checkLeft.execute(inliningTarget, left) || !checkRight.execute(inliningTarget, right)) {
+                return PNotImplemented.NOT_IMPLEMENTED;
+            }
             return stringEqOpHelperNode.execute(inliningTarget, left, right, opCode == ComparisonOp.NE.opCode);
         }
 
         @Specialization(guards = {"opCode == cachedOp.opCode", "!isEqualityOpCode(opCode)"}, limit = "4")
         static Object doRelOp(Object left, Object right, @SuppressWarnings("unused") int opCode,
                         @Bind("this") Node inliningTarget,
+                        @Exclusive @Cached PyUnicodeCheckNode checkLeft,
+                        @Exclusive @Cached PyUnicodeCheckNode checkRight,
                         @Cached("fromOpCode(opCode)") ComparisonOp cachedOp,
                         @Cached StringCmpOpHelperNode stringCmpOpHelperNode) {
+            if (!checkLeft.execute(inliningTarget, left) || !checkRight.execute(inliningTarget, right)) {
+                return PNotImplemented.NOT_IMPLEMENTED;
+            }
             return stringCmpOpHelperNode.execute(inliningTarget, left, right, cachedOp.intPredicate);
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/tuple/TupleBuiltins.java

@@ -107,6 +107,7 @@
 import com.oracle.truffle.api.HostCompilerDirectives.InliningCutoff;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.dsl.Cached.Shared;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateCached;
@@ -419,21 +420,26 @@ abstract static class RichCompareNode extends PythonTernaryBuiltinNode {
         @Specialization(guards = {"opCode == cachedOp.opCode"}, limit = "6")
         static Object doPTuple(VirtualFrame frame, PTuple left, PTuple right, @SuppressWarnings("unused") int opCode,
                         @SuppressWarnings("unused") @Cached("fromOpCode(opCode)") ComparisonOp cachedOp,
-                        @Cached("createCmpNode(cachedOp)") SequenceStorageNodes.CmpNode cmpNode) {
+                        @Exclusive @Cached("createCmpNode(cachedOp)") SequenceStorageNodes.CmpNode cmpNode) {
             return cmpNode.execute(frame, left.getSequenceStorage(), right.getSequenceStorage());
         }
 
-        @Specialization(guards = {"opCode == cachedOp.opCode", "checkRight.execute(inliningTarget, right)"}, limit = "6", replaces = "doPTuple")
-        static Object doRelOp(VirtualFrame frame, Object left, Object right, @SuppressWarnings("unused") int opCode,
+        @Specialization(guards = {"opCode == cachedOp.opCode"}, limit = "6", replaces = "doPTuple")
+        static Object doGeneric(VirtualFrame frame, Object left, Object right, @SuppressWarnings("unused") int opCode,
                         @Bind("this") Node inliningTarget,
                         @SuppressWarnings("unused") @Cached("fromOpCode(opCode)") ComparisonOp cachedOp,
-                        @SuppressWarnings("unused") @Cached PyTupleCheckNode checkRight,
+                        @Cached PyTupleCheckNode checkLeft,
+                        @Cached PyTupleCheckNode checkRight,
                         @Cached GetTupleStorage getLeft,
                         @Cached GetTupleStorage getRight,
-                        @Cached("createCmpNode(cachedOp)") SequenceStorageNodes.CmpNode cmpNode) {
+                        @Exclusive @Cached("createCmpNode(cachedOp)") SequenceStorageNodes.CmpNode cmpNode) {
+            if (!checkLeft.execute(inliningTarget, left) || !checkRight.execute(inliningTarget, right)) {
+                return PNotImplemented.NOT_IMPLEMENTED;
+            }
             return cmpNode.execute(frame, getLeft.execute(inliningTarget, left), getRight.execute(inliningTarget, right));
         }
 
+        @NeverDefault
         static SequenceStorageNodes.CmpNode createCmpNode(ComparisonOp op) {
             switch (op) {
                 case LE: