Untag transient test_zipfile.test_many_opens

msimacek · msimacek · commit e66a984a1b50 · 2024-11-12T00:16:28.000+01:00
diff --git a/graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_zipfile.txt b/graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_zipfile.txt
@@ -268,7 +268,6 @@ test.test_zipfile.TestWithDirectory.test_write_dir
 test.test_zipfile.TestWithDirectory.test_writestr_dir
 test.test_zipfile.TestsWithMultipleOpens.test_different_file
 test.test_zipfile.TestsWithMultipleOpens.test_interleaved
-test.test_zipfile.TestsWithMultipleOpens.test_many_opens
 test.test_zipfile.TestsWithMultipleOpens.test_read_after_close
 test.test_zipfile.TestsWithMultipleOpens.test_read_after_write
 test.test_zipfile.TestsWithMultipleOpens.test_same_file
diff --git a/graalpython/lib-python/3/test/conftest.toml b/graalpython/lib-python/3/test/conftest.toml
@@ -29,7 +29,6 @@ selector = [
     # test_int contains a denial-of-service prevention test that requires to finish within a certain time.
     # We are actually fast enough but the parallel execution overhead can cause transient failures.
     'test_int',
-    'test_zipfile',
 ]
 
 [[test_rules]]
diff --git a/mx.graalpython/mx_graalpython.py b/mx.graalpython/mx_graalpython.py
@@ -634,6 +634,8 @@ def update_unittest_tags(args):
         'test.test_multiprocessing_spawn.test_misc.TestResourceTracker.test_resource_tracker_sigkill',
         # Connecting to external page that sometimes times out
         'graalpython.lib-python.3.test.test_urllib2net.OtherNetworkTests.test_ftp',
+        # Counting file descriptors, can randomly change due to finalizers
+        'graalpython.lib-python.3.test.test_zipfile.TestsWithMultipleOpens.test_many_opens',
     ]
 
     result_tags = linux_tags & darwin_tags

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ selector = [`
`29`	`29`	`# test_int contains a denial-of-service prevention test that requires to finish within a certain time.`
`30`	`30`	`# We are actually fast enough but the parallel execution overhead can cause transient failures.`
`31`	`31`	`'test_int',`
`32`		`- 'test_zipfile',`
`33`	`32`	`]`
`34`	`33`
`35`	`34`	`[[test_rules]]`
Original file line number	Diff line number	Diff line change
`@@ -634,6 +634,8 @@ def update_unittest_tags(args):`
`634`	`634`	`'test.test_multiprocessing_spawn.test_misc.TestResourceTracker.test_resource_tracker_sigkill',`
`635`	`635`	`# Connecting to external page that sometimes times out`
`636`	`636`	`'graalpython.lib-python.3.test.test_urllib2net.OtherNetworkTests.test_ftp',`
	`637`	`+ # Counting file descriptors, can randomly change due to finalizers`
	`638`	`+ 'graalpython.lib-python.3.test.test_zipfile.TestsWithMultipleOpens.test_many_opens',`
`637`	`639`	`]`
`638`	`640`
`639`	`641`	`result_tags = linux_tags & darwin_tags`