[GR-12774] Disable eval of internal sources through polyglot api

PullRequest: graalpython/305

Author: timfel

graalpython/com.oracle.graal.python.test/src/tests/test_interop.py

@@ -250,3 +250,11 @@ def test_host_lookup():
             assert True
         else:
             assert False, "requesting a non-existing host symbol should raise KeyError"
+
+    def test_internal_languages_dont_eval():
+        try:
+            polyglot.eval(language="nfi", string="default")
+        except NotImplementedError as e:
+            assert "internal language" in str(e)
+
+        assert polyglot.eval(language="python", string="21 * 2") == 42

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/InteropModuleBuiltins.java

@@ -130,6 +130,7 @@ Object evalString(@SuppressWarnings("unused") PNone path, String value, String l
             try {
                 boolean mimeType = isMimeType(langOrMimeType);
                 String lang = mimeType ? findLanguageByMimeType(env, langOrMimeType) : langOrMimeType;
+                raiseIfInternal(env, lang);
                 LiteralBuilder newBuilder = Source.newBuilder(lang, value, value);
                 if (mimeType) {
                     newBuilder = newBuilder.mimeType(langOrMimeType);
@@ -140,13 +141,21 @@ Object evalString(@SuppressWarnings("unused") PNone path, String value, String l
             }
         }
 
+        private void raiseIfInternal(Env env, String lang) {
+            LanguageInfo languageInfo = env.getLanguages().get(lang);
+            if (languageInfo != null && languageInfo.isInternal()) {
+                throw raise(NotImplementedError, "access to internal language %s is not permitted", lang);
+            }
+        }
+
         @TruffleBoundary
         @Specialization
         Object evalFile(String path, @SuppressWarnings("unused") PNone string, String langOrMimeType) {
             Env env = getContext().getEnv();
             try {
                 boolean mimeType = isMimeType(langOrMimeType);
                 String lang = mimeType ? findLanguageByMimeType(env, langOrMimeType) : langOrMimeType;
+                raiseIfInternal(env, lang);
                 SourceBuilder newBuilder = Source.newBuilder(lang, env.getTruffleFile(path));
                 if (mimeType) {
                     newBuilder = newBuilder.mimeType(langOrMimeType);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SREModuleBuiltins.java

@@ -80,6 +80,7 @@
 import com.oracle.truffle.api.interop.UnsupportedTypeException;
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.profiles.BranchProfile;
+import com.oracle.truffle.api.source.Source;
 import com.oracle.truffle.regex.RegexSyntaxException;
 
 @CoreFunctions(defineModule = "_sre")
@@ -89,6 +90,16 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
         return SREModuleBuiltinsFactory.getFactories();
     }
 
+    @Builtin(name = "_build_regex_engine", fixedNumOfPositionalArgs = 1)
+    @GenerateNodeFactory
+    abstract static class BuildRegexEngine extends PythonUnaryBuiltinNode {
+        @Specialization
+        @TruffleBoundary
+        Object run(String code) {
+            return getContext().getEnv().parse(Source.newBuilder("regex", code, "build-regex-engine").build()).call();
+        }
+    }
+
     /**
      * Replaces any <it>quoted</it> escape sequence like {@code "\\n"} (two characters; backslash +
      * 'n') by its single character like {@code "\n"} (one character; newline).

graalpython/lib-graalpython/_sre.py

@@ -99,7 +99,7 @@ def executable_pattern(regex_object, input, from_index):
 
         return fallback_compiler
 
-    engine_builder = _interop.eval(string="", language="regex")
+    engine_builder = _build_regex_engine("")
 
     global TREGEX_ENGINE_STR
     global TREGEX_ENGINE_BYTES