Raise OverflowError when converting too large integers to float

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -25,6 +25,7 @@
  */
 package com.oracle.graal.python.builtins.modules;
 
+import static com.oracle.graal.python.builtins.PythonBuiltinClassType.OverflowError;
 import static com.oracle.graal.python.builtins.objects.cext.NativeCAPISymbols.FUN_ADD_NATIVE_SLOTS;
 import static com.oracle.graal.python.builtins.objects.cext.NativeCAPISymbols.FUN_PY_OBJECT_GENERIC_NEW;
 import static com.oracle.graal.python.builtins.objects.slice.PSlice.MISSING_INDEX;
@@ -967,11 +968,16 @@ Object floatFromLong(LazyPythonClass cls, long arg) {
         }
 
         @Specialization(guards = "!isNativeClass(cls)")
-        Object floatFromPInt(LazyPythonClass cls, PInt arg) {
+        Object floatFromPInt(LazyPythonClass cls, PInt arg,
+                        @Cached PRaiseNode raise) {
+            double value = arg.doubleValue();
+            if (Double.isInfinite(value)) {
+                throw raise.raise(OverflowError, "int too large to convert to float");
+            }
             if (isPrimitiveFloat(cls)) {
-                return arg.doubleValue();
+                return value;
             }
-            return factory().createFloat(cls, arg.doubleValue());
+            return factory().createFloat(cls, value);
         }
 
         @Specialization(guards = "!isNativeClass(cls)")
@@ -2544,7 +2550,7 @@ private String mangle(String privateobj, String ident) {
             plen -= ipriv;
 
             if ((long) plen + nlen >= Integer.MAX_VALUE) {
-                throw raise(PythonBuiltinClassType.OverflowError, "private identifier too large to be mangled");
+                throw raise(OverflowError, "private identifier too large to be mangled");
             }
 
             /* ident = "_" + priv[ipriv:] + ident # i.e. 1+plen+nlen bytes */

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/util/CastToDoubleNode.java

@@ -40,6 +40,7 @@
  */
 package com.oracle.graal.python.nodes.util;
 
+import static com.oracle.graal.python.runtime.exception.PythonErrorType.OverflowError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 
 import com.oracle.graal.python.builtins.modules.MathGuards;
@@ -75,8 +76,13 @@ public double toDouble(long x) {
     }
 
     @Specialization
-    public double toDouble(PInt x) {
-        return x.doubleValue();
+    public double toDouble(PInt x,
+                    @Cached PRaiseNode raise) {
+        double value = x.doubleValue();
+        if (Double.isInfinite(value)) {
+            throw raise.raise(OverflowError, "int too large to convert to float");
+        }
+        return value;
     }
 
     @Specialization