Flip endianness argument

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextLongBuiltins.java

@@ -480,7 +480,7 @@ static Object convert(Object charPtr, long size, int littleEndian, int signed,
                 throw raiseNode.get(inliningTarget).raise(OverflowError, ErrorMessages.BYTE_ARRAY_TOO_LONG_TO_CONVERT_TO_INT);
             }
             byte[] bytes = readByteNode.readByteArray(charPtr, (int) size);
-            return fromByteArray.execute(inliningTarget, bytes, littleEndian == 0, signed != 0);
+            return fromByteArray.execute(inliningTarget, bytes, littleEndian != 0, signed != 0);
         }
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cjkcodecs/MultibyteIncrementalEncoderBuiltins.java

@@ -286,7 +286,7 @@ static Object getstate(MultibyteIncrementalEncoderObject self,
             // for the encoder object.
             // memcpy(statebytes + statesize, self.state.c, MULTIBYTECODECSTATE);
             // statesize += MULTIBYTECODECSTATE;
-            Object stateobj = fromByteArray.execute(inliningTarget, statebytes, false, true);
+            Object stateobj = fromByteArray.execute(inliningTarget, statebytes, true, true);
             assert (stateobj instanceof PInt); // since statebytes.length > 8, we will get a PInt
             writeHiddenAttrNode.execute(inliningTarget, (PInt) stateobj, HiddenAttr.ENCODER_OBJECT, self.state);
             return stateobj;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/PTextIO.java

@@ -421,7 +421,7 @@ public static Object build(CookieType cookie) {
             SERIALIZE.putInt(buffer, Long.BYTES + Integer.BYTES, cookie.bytesToFeed);
             SERIALIZE.putInt(buffer, Long.BYTES + Integer.BYTES * 2, cookie.charsToSkip);
             SERIALIZE.putByte(buffer, Long.BYTES + Integer.BYTES * 3, cookie.needEOF);
-            return IntNodes.PyLongFromByteArray.executeUncached(buffer, false, false);
+            return IntNodes.PyLongFromByteArray.executeUncached(buffer, true, false);
         }
 
         public static CookieType parse(long v, Node inliningTarget, InlinedConditionProfile overflow, PRaiseNode.Lazy raise) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/pickle/PUnpickler.java

@@ -696,12 +696,12 @@ protected HashingStorageAddAllToOther ensureHashingStorageAddAllToOther() {
             return addAllToOther;
         }
 
-        protected Object longFromBytes(byte[] data, boolean bigEndian) {
+        protected Object longFromBytes(byte[] data, boolean littleEndian) {
             if (pyLongFromByteArray == null) {
                 CompilerDirectives.transferToInterpreterAndInvalidate();
                 pyLongFromByteArray = insert(IntNodesFactory.PyLongFromByteArrayNodeGen.create());
             }
-            return pyLongFromByteArray.executeCached(data, bigEndian, true);
+            return pyLongFromByteArray.executeCached(data, littleEndian, true);
         }
 
         protected void setAttribute(VirtualFrame frame, Object object, Object key, Object value) {
@@ -910,7 +910,7 @@ private void loadCountedLong(VirtualFrame frame, PUnpickler self, int n) {
             } else {
                 // Read the raw little-endian bytes and convert.
                 final ByteArrayView pdata = read(frame, self, size);
-                value = longFromBytes(pdata.getBytes(size), false);
+                value = longFromBytes(pdata.getBytes(size), true);
             }
             pDataPush(self, value);
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntBuiltins.java

@@ -2841,11 +2841,11 @@ static Object fromObject(VirtualFrame frame, Object cl, Object object, TruffleSt
                         @Cached IntNodes.PyLongFromByteArray fromByteArray,
                         @Cached CallNode callCtor,
                         @Cached PRaiseNode.Lazy raiseNode) {
-            boolean bigEndian;
+            boolean littleEndian;
             if (equalNode.execute(byteorder, T_BIG, TS_ENCODING)) {
-                bigEndian = true;
+                littleEndian = false;
             } else if (equalNode.execute(byteorder, T_LITTLE, TS_ENCODING)) {
-                bigEndian = false;
+                littleEndian = true;
             } else {
                 throw raiseNode.get(inliningTarget).raise(PythonErrorType.ValueError, ErrorMessages.BYTEORDER_MUST_BE_LITTLE_OR_BIG);
             }
@@ -2860,7 +2860,7 @@ static Object fromObject(VirtualFrame frame, Object cl, Object object, TruffleSt
             } else {
                 bytes = bytesFromObject.execute(frame, object);
             }
-            Object result = fromByteArray.execute(inliningTarget, bytes, bigEndian, signed);
+            Object result = fromByteArray.execute(inliningTarget, bytes, littleEndian, signed);
             if (isBuiltinIntProfile.profileClass(inliningTarget, cl, PythonBuiltinClassType.PInt)) {
                 return result;
             } else {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntNodes.java

@@ -180,26 +180,26 @@ static byte[] doPInt(Node inliningTarget, PInt value, int size, boolean bigEndia
     @GenerateInline(inlineByDefault = true)
     @GenerateUncached
     public abstract static class PyLongFromByteArray extends Node {
-        public abstract Object execute(Node inliningTarget, byte[] data, boolean bigEndian, boolean signed);
+        public abstract Object execute(Node inliningTarget, byte[] data, boolean littleEndian, boolean signed);
 
-        public final Object executeCached(byte[] data, boolean bigEndian, boolean signed) {
-            return execute(this, data, bigEndian, signed);
+        public final Object executeCached(byte[] data, boolean littleEndian, boolean signed) {
+            return execute(this, data, littleEndian, signed);
         }
 
-        public static Object executeUncached(byte[] data, boolean bigEndian, boolean signed) {
-            return IntNodesFactory.PyLongFromByteArrayNodeGen.getUncached().execute(null, data, bigEndian, signed);
+        public static Object executeUncached(byte[] data, boolean littleEndian, boolean signed) {
+            return IntNodesFactory.PyLongFromByteArrayNodeGen.getUncached().execute(null, data, littleEndian, signed);
         }
 
         @Specialization
-        static Object doOther(Node inliningTarget, byte[] data, boolean bigEndian, boolean signed,
+        static Object doOther(Node inliningTarget, byte[] data, boolean littleEndian, boolean signed,
                         @Cached InlinedBranchProfile fastPath1,
                         @Cached InlinedBranchProfile fastPath2,
                         @Cached InlinedBranchProfile fastPath4,
                         @Cached InlinedBranchProfile fastPath8,
                         @Cached InlinedBranchProfile generic,
                         @Cached(inline = false) PythonObjectFactory factory,
                         @Cached PRaiseNode.Lazy raiseNode) {
-            NumericSupport support = bigEndian ? NumericSupport.bigEndian() : NumericSupport.littleEndian();
+            NumericSupport support = littleEndian ? NumericSupport.littleEndian() : NumericSupport.bigEndian();
             if (signed) {
                 switch (data.length) {
                     case 1 -> {