Skip to content

Commit efe2cfc

Browse files
committed
Get rid of benchmarks running from an old-style graalvm
1 parent b1f5ef4 commit efe2cfc

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

mx.graalpython/mx_graalpython_benchmark.py

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,6 @@ def hosting_registry(self):
345345
def launcher_class(self):
346346
raise NotImplementedError()
347347

348-
def run_in_graalvm(self, cwd, args, extra_polyglot_args, host_vm):
349-
raise NotImplementedError()
350-
351348
def get_extra_polyglot_args(self):
352349
raise NotImplementedError()
353350

@@ -374,8 +371,6 @@ def run(self, cwd, args):
374371
extra_polyglot_args = self.get_extra_polyglot_args()
375372

376373
host_vm = self.host_vm()
377-
if hasattr(host_vm, 'run_lang'): # this is a full GraalVM build
378-
return self.run_in_graalvm(cwd, args, extra_polyglot_args, host_vm)
379374

380375
# Otherwise, we're running from the source tree
381376
args = self._remove_vm_prefix_for_all(args)
@@ -457,14 +452,6 @@ def run(self, cwd, args):
457452
sys.exit(1)
458453
return super().run(cwd, args)
459454

460-
def run_in_graalvm(self, cwd, args, extra_polyglot_args, host_vm):
461-
with environ(self._env or {}):
462-
cp = self.get_classpath()
463-
if len(cp) > 0:
464-
extra_polyglot_args.append("--vm.classpath=" + ":".join(cp))
465-
launcher_name = 'graalpy'
466-
return self._validate_output(*host_vm.run_launcher(launcher_name, extra_polyglot_args + args, cwd))
467-
468455
def get_extra_polyglot_args(self):
469456
return ["--experimental-options", "-snapshot-startup", "--python.MaxNativeMemory=%s" % (2**34)] + self._extra_polyglot_args
470457

@@ -480,10 +467,9 @@ def __init__(self, config_name=CONFIGURATION_DEFAULT, cp_suffix=None, distributi
480467
def launcher_class(self):
481468
return 'com.oracle.graal.python.benchmarks.JavaBenchmarkDriver'
482469

483-
def run_in_graalvm(self, cwd, args, extra_polyglot_args, host_vm):
484-
# In GraalVM we run the Java benchmarks driver like one would run any other Java application
485-
# that embeds GraalPython on GraalVM. We need to add the dependencies on class path, and since
486-
# we use run_java, we need to do some output postprocessing that normally run_launcher would do
470+
def run(self, cwd, args):
471+
extra_polyglot_args = self.get_extra_polyglot_args()
472+
host_vm = self.host_vm()
487473
with environ(self._env or {}):
488474
cp = self.get_classpath()
489475
jhm = mx.dependency("mx:JMH_1_21")

0 commit comments

Comments
 (0)