Skip to content

Commit f1bb263

Browse files
committed
Fix failed library assertion in HPy nodes
1 parent 96eb044 commit f1bb263

File tree

1 file changed

+13
-13
lines changed
  • graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/hpy

1 file changed

+13
-13
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/hpy/GraalHPyNodes.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,7 @@ public abstract static class HPyCreateGetSetDescriptorNode extends PNodeWithCont
779779

780780
@Specialization(limit = "1")
781781
static GetSetDescriptor doIt(GraalHPyContext context, Object type, Object memberDef,
782-
@CachedLibrary("memberDef") InteropLibrary interopLibrary,
782+
@CachedLibrary("memberDef") InteropLibrary memberDefLib,
783783
@CachedLibrary(limit = "2") InteropLibrary valueLib,
784784
@Cached GetNameNode getNameNode,
785785
@Cached FromCharPointerNode fromCharPointerNode,
@@ -788,37 +788,37 @@ static GetSetDescriptor doIt(GraalHPyContext context, Object type, Object member
788788
@Cached WriteAttributeToDynamicObjectNode writeDocNode,
789789
@Cached PRaiseNode raiseNode) {
790790

791-
assert interopLibrary.hasMembers(memberDef);
792-
assert interopLibrary.isMemberReadable(memberDef, "name");
793-
assert interopLibrary.isMemberReadable(memberDef, "getter_impl");
794-
assert interopLibrary.isMemberReadable(memberDef, "setter_impl");
795-
assert interopLibrary.isMemberReadable(memberDef, "doc");
796-
assert interopLibrary.isMemberReadable(memberDef, "closure");
791+
assert memberDefLib.hasMembers(memberDef);
792+
assert memberDefLib.isMemberReadable(memberDef, "name");
793+
assert memberDefLib.isMemberReadable(memberDef, "getter_impl");
794+
assert memberDefLib.isMemberReadable(memberDef, "setter_impl");
795+
assert memberDefLib.isMemberReadable(memberDef, "doc");
796+
assert memberDefLib.isMemberReadable(memberDef, "closure");
797797

798798
String enclosingClassName = getNameNode.execute(type);
799799
try {
800800
String name;
801801
try {
802-
name = castToJavaStringNode.execute(fromCharPointerNode.execute(interopLibrary.readMember(memberDef, "name")));
802+
name = castToJavaStringNode.execute(fromCharPointerNode.execute(memberDefLib.readMember(memberDef, "name")));
803803
} catch (CannotCastException e) {
804804
throw CompilerDirectives.shouldNotReachHere("Cannot cast member name to string");
805805
}
806806

807807
// note: 'doc' may be NULL; in this case, we would store 'None'
808808
Object memberDoc = PNone.NONE;
809-
Object docCharPtr = interopLibrary.readMember(memberDef, "doc");
809+
Object docCharPtr = memberDefLib.readMember(memberDef, "doc");
810810
if (!valueLib.isNull(docCharPtr)) {
811811
memberDoc = fromCharPointerNode.execute(docCharPtr);
812812
}
813813

814-
Object closurePtr = interopLibrary.readMember(memberDef, "closure");
814+
Object closurePtr = memberDefLib.readMember(memberDef, "closure");
815815

816816
// signature: self, closure
817-
Object getterFunctionPtr = interopLibrary.readMember(memberDef, "getter_impl");
817+
Object getterFunctionPtr = memberDefLib.readMember(memberDef, "getter_impl");
818818

819819
// signature: self, value, closure
820-
Object setterFunctionPtr = interopLibrary.readMember(memberDef, "setter_impl");
821-
boolean readOnly = interopLibrary.isNull(setterFunctionPtr);
820+
Object setterFunctionPtr = memberDefLib.readMember(memberDef, "setter_impl");
821+
boolean readOnly = valueLib.isNull(setterFunctionPtr);
822822

823823
PFunction getterObject = HPyGetSetDescriptorGetterRootNode.createFunction(context.getContext(), enclosingClassName, name, getterFunctionPtr, closurePtr);
824824
Object setterObject;

0 commit comments

Comments
 (0)