Skip to content

Commit f1d9d47

Browse files
committed
Fix invalid usages of ReportPolymorphism
1 parent cb7adba commit f1d9d47

File tree

4 files changed

+3
-12
lines changed

4 files changed

+3
-12
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@
109109
import com.oracle.graal.python.builtins.Python3Core;
110110
import com.oracle.graal.python.builtins.PythonBuiltinClassType;
111111
import com.oracle.graal.python.builtins.PythonBuiltins;
112-
import com.oracle.graal.python.builtins.modules.WarningsModuleBuiltins.WarnNode;
113112
import com.oracle.graal.python.builtins.modules.BuiltinConstructorsFactory.FloatNodeFactory.NonPrimitiveFloatNodeGen;
114113
import com.oracle.graal.python.builtins.modules.BuiltinConstructorsFactory.ObjectNodeFactory.ReportAbstractClassNodeGen;
114+
import com.oracle.graal.python.builtins.modules.WarningsModuleBuiltins.WarnNode;
115115
import com.oracle.graal.python.builtins.objects.PNone;
116116
import com.oracle.graal.python.builtins.objects.PNotImplemented;
117117
import com.oracle.graal.python.builtins.objects.buffer.PythonBufferAccessLibrary;
@@ -1081,7 +1081,6 @@ static Object reversed(VirtualFrame frame, Object cls, Object sequence,
10811081
// float([x])
10821082
@Builtin(name = J_FLOAT, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, constructsClass = PythonBuiltinClassType.PFloat, doc = "Convert a string or number to a floating point number, if possible.")
10831083
@GenerateNodeFactory
1084-
@ReportPolymorphism
10851084
abstract static class FloatNode extends PythonBinaryBuiltinNode {
10861085

10871086
@Child NonPrimitiveFloatNode nonPrimitiveFloatNode;
@@ -1874,7 +1873,6 @@ private static String newString(byte[] bytes, int offset, int length) {
18741873
The builtins True and False are the only two instances of the class bool.
18751874
The class bool is a subclass of the class int, and cannot be subclassed.""")
18761875
@GenerateNodeFactory
1877-
@ReportPolymorphism
18781876
public abstract static class BoolNode extends PythonBinaryBuiltinNode {
18791877
@Specialization
18801878
public static boolean bool(VirtualFrame frame, @SuppressWarnings("unused") Object cls, Object obj,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/WarningsModuleBuiltins.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@
134134
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
135135
import com.oracle.truffle.api.dsl.NeverDefault;
136136
import com.oracle.truffle.api.dsl.NodeFactory;
137-
import com.oracle.truffle.api.dsl.ReportPolymorphism;
138137
import com.oracle.truffle.api.dsl.Specialization;
139138
import com.oracle.truffle.api.frame.Frame;
140139
import com.oracle.truffle.api.frame.VirtualFrame;
@@ -983,7 +982,6 @@ private static TruffleString getSourceLine(Node node, PDict globals, int lineno)
983982
}
984983
}
985984

986-
@ReportPolymorphism
987985
@Builtin(name = J_WARN, minNumOfPositionalArgs = 2, parameterNames = {"$mod", "message", "category", "stacklevel", "source"}, declaresExplicitSelf = true, alwaysNeedsCallerFrame = true)
988986
@ArgumentClinic(name = "category", defaultValue = "PNone.NONE")
989987
@ArgumentClinic(name = "stacklevel", conversion = ClinicConversion.Int, defaultValue = "1")
@@ -1013,7 +1011,6 @@ public static WarnBuiltinNode create() {
10131011

10141012
}
10151013

1016-
@ReportPolymorphism
10171014
@Builtin(name = J_WARN_EXPLICIT, minNumOfPositionalArgs = 5, //
10181015
parameterNames = {"$mod", "message", "category", "filename", "lineno", "module", "registry", "module_globals", "source"}, declaresExplicitSelf = true)
10191016
@ArgumentClinic(name = "lineno", conversion = ClinicConversion.Int)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupAndCallNonReversibleBinaryNode.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
@@ -57,15 +57,13 @@
5757
import com.oracle.truffle.api.dsl.Cached.Exclusive;
5858
import com.oracle.truffle.api.dsl.ImportStatic;
5959
import com.oracle.truffle.api.dsl.NeverDefault;
60-
import com.oracle.truffle.api.dsl.ReportPolymorphism;
6160
import com.oracle.truffle.api.dsl.ReportPolymorphism.Megamorphic;
6261
import com.oracle.truffle.api.dsl.Specialization;
6362
import com.oracle.truffle.api.frame.VirtualFrame;
6463
import com.oracle.truffle.api.nodes.Node;
6564
import com.oracle.truffle.api.strings.TruffleString;
6665

6766
@ImportStatic(PythonOptions.class)
68-
@ReportPolymorphism
6967
abstract class LookupAndCallNonReversibleBinaryNode extends LookupAndCallBinaryNode {
7068
protected final SpecialMethodSlot slot;
7169
protected final TruffleString name;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupAndCallReversibleBinaryNode.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
@@ -62,7 +62,6 @@
6262
import com.oracle.truffle.api.dsl.Cached;
6363
import com.oracle.truffle.api.dsl.Cached.Exclusive;
6464
import com.oracle.truffle.api.dsl.ImportStatic;
65-
import com.oracle.truffle.api.dsl.ReportPolymorphism;
6665
import com.oracle.truffle.api.dsl.ReportPolymorphism.Megamorphic;
6766
import com.oracle.truffle.api.dsl.Specialization;
6867
import com.oracle.truffle.api.frame.VirtualFrame;
@@ -76,7 +75,6 @@
7675
//
7776
// [*] only when v->ob_type != w->ob_type && w->ob_type is a subclass of v->ob_type
7877
@ImportStatic(PythonOptions.class)
79-
@ReportPolymorphism
8078
abstract class LookupAndCallReversibleBinaryNode extends LookupAndCallBinaryNode {
8179

8280
protected final SpecialMethodSlot slot;

0 commit comments

Comments
 (0)